privacybadger icon indicating copy to clipboard operation
privacybadger copied to clipboard

Strip UTM parameters from third-party https requests

Open bcyphers opened this issue 6 years ago • 5 comments

https://github.com/EFForg/privacybadger/issues/681#issuecomment-418866833

Strip Urchin Tracking Module (UTM) parameters from URLs in main-frame and third-party background requests. Only operate on https:// urls to avoid conflicts with HTTPSE. Leave first-party background requests and private or social widget requests alone.

bcyphers avatar Sep 07 '18 21:09 bcyphers

Again, the test failure comes from a timeout. I'll rebase in order to trigger the tests again.

bcyphers avatar Sep 17 '18 19:09 bcyphers

And now this:

E       selenium.common.exceptions.WebDriverException: Message: Socket timeout reading Marionette handshake data: Resource temporarily unavailable (os error 11)

bcyphers avatar Sep 17 '18 19:09 bcyphers

Might be worth handling fbclid parameters as well: http://thisinterestsme.com/facebook-fbclid-parameter/

bcyphers avatar Oct 23 '18 22:10 bcyphers

We just got a PR to remove "fbclid" from outgoing Facebook links as part of existing Facebook link cleaning: #2207.

ghostwords avatar Oct 29 '18 15:10 ghostwords

Also worth removing gclid parameters, Google's version of fbclid. https://www.wordstream.com/gclid

bcyphers avatar Mar 25 '19 20:03 bcyphers