privacybadger icon indicating copy to clipboard operation
privacybadger copied to clipboard

Add solvemedia.com to yellowlist

Open ghostwords opened this issue 8 years ago • 5 comments

Fixes #1191.

ghostwords avatar Aug 03 '17 21:08 ghostwords

By the way, I see "database storage" being used by api.solvemedia.com but I have trouble getting Chrome dev tools to show me the contents.

screenshot from 2017-08-03 17 37 57

screenshot from 2017-08-03 17 38 08

ghostwords avatar Aug 03 '17 21:08 ghostwords

@ghostwords I suspect that this is either indexedDB or web SQL. I looked into a way for clients to inspect local indexedDB data on an origin. Unfortunately the way to do this has been removed recently. I've followed up with chrome to get this restored.

It seems that the only way we can get this data is to monitor indexedDB access on clients and record database names.

cowlicks avatar Aug 04 '17 18:08 cowlicks

Subdomains of yellowlisted domains should end up getting "cookieblocked".

Agreed, we should add tests for the various scenarios of adding domains to the yellowlist and what effect that has on their heuristicAction properties. That to me is what #1515 is about. [Update: 372c0098c968a25db2d81c434ccafbb1f52b91de adds a basic test of a domain going from "block" to "cookieblock".]

I think we should be careful about the distinction between something being "yellowlisted" (added to our exception list of domains but not directly used by Privacy Badger's decisioning) and something being "cookieblocked" (a Privacy Badger decision state, distinct from blocked, not-yet-blocked, or non-tracking).

We do have a test for when you have a blocked subdomain and a cookieblocked parent domain:

https://github.com/EFForg/privacybadger/blob/9ebc49c624e57a2e6c5a3b75871d4ddee320110c/src/tests/tests/storage.js#L280-L309

ghostwords avatar Aug 22 '17 15:08 ghostwords

@cowlicks Should we yellowlist solvemedia.com even though it sets database storage?

ghostwords avatar Aug 22 '17 15:08 ghostwords

Opened a crbug re inability to inspect IndexedDB contents in Chrome settings/dev tools: https://bugs.chromium.org/p/chromium/issues/detail?id=930773

ghostwords avatar Feb 11 '19 18:02 ghostwords