https-everywhere icon indicating copy to clipboard operation
https-everywhere copied to clipboard

Direct HTTP link to a Firefox extension doesn't redirect correctly if EASE is enabled

Open kidhanis opened this issue 5 years ago • 5 comments

Type: code issue

This might be related to #17774. I've tested with HTTPS Everywhere version 2019.6.27 and the latest Beta and Nightly versions of Firefox.

Steps to reproduce:

  1. Enable EASE.
  2. Find an HTTPS URL to an .xpi file, change it to HTTP, and visit the modified URL. For example, try clicking on http://www.eff.org/files/https-everywhere-2019.6.27-eff.xpi.

Expected results:

The browser prompts the user to download and to install the extension.

Actual results:

The page gets redirected to the moz-extension:// blocking page and the .xpi file cannot be downloaded.

kidhanis avatar Jul 17 '19 00:07 kidhanis

I think the reason is Firefox doesn't let you tamper with .xpi requests.

pipboy96 avatar Jul 18 '19 11:07 pipboy96

I think the reason is Firefox doesn't let you tamper with .xpi requests.

But this is strange, www.eff.org is preloaded https://hstspreload.org/?domain=www.eff.org. This request should, thoretically, always go through HTTPS...

Update:

For some domains that are preloaded and without ruleset coverage, e.g. http://hstspreload.org/https-everywhere.xpi, http://youtube.com/https-everywhere.xpi, http://bugzilla.mozilla.org/https-everywhere.xpi the URLs are redirected correctly.

For domains that are not preloaded and without ruleset coverage, e.g. http://http.badssl.com/https-everywhere.xpi the warning page also appears.

For domains that are not preloaded and with ruleset coverage, e.g. http://www.google.com/https-everywhere.xpi, the URL is redirected to HTTPS correctly.

A reasonable deduction from the above is that *.eff.org is not preloaded. But it appears on the firefox preload list https://hg.mozilla.org/releases/mozilla-release/raw-file/FIREFOX_68_0_RELEASE/security/manager/ssl/nsSTSPreloadList.inc

cschanaj avatar Jul 18 '19 12:07 cschanaj

Should be fixed by #18233.

pipboy96 avatar Sep 28 '19 04:09 pipboy96

This issue still exists, cc @zoracon.

pipboy96 avatar Sep 28 '19 04:09 pipboy96

Revisiting, when I click on http://www.eff.org/files/https-everywhere-2019.6.27-eff.xpi, i get the install prompt. Is that still not the case for others?

zoracon avatar Nov 17 '20 19:11 zoracon