actioncenter-mobile icon indicating copy to clipboard operation
actioncenter-mobile copied to clipboard

Published 20 hours ago • verified publisher icon EFForg

Action Feed: Style 'Share this app!'

Open maximillianh opened this issue 9 years ago • 10 comments

Now that we have an action feed, the 'Share this' action needs to be styled consistently with the other items in that feed.

maximillianh avatar Feb 20 '16 22:02 maximillianh

This item is actually a bit different - "Take Action" and "Share This Action" are the same thing. I think we need to get rid of one of the buttons.

i.e. we need some changes to the markup in addition to fixing up the styling.

mfb avatar Feb 23 '16 02:02 mfb

Also I would say the message shown to the app user should be different from the message that is actually shared.

mfb avatar Feb 23 '16 02:02 mfb

Wait, how is this different from #51?

jpt avatar Feb 23 '16 19:02 jpt

I think this needs some more design work. Do we really want this to have "Take Action" and "Share This Action" buttons?

mfb avatar Feb 23 '16 21:02 mfb

@mfb this issue referred to the way 'Share this action!' is displayed in the actionItems feed, but we should definitely make the markup changes to the modal as well.

maximillianh avatar Feb 23 '16 22:02 maximillianh

hrm this appears to be broken now

mfb avatar Feb 24 '16 06:02 mfb

screen

mfb avatar Feb 24 '16 06:02 mfb

The latest release seems to have broken the path to the no-image eff logo png on my device. Cannot reproduce on my dev instance. modal

maximillianh avatar Feb 25 '16 07:02 maximillianh

@jeremytribby I've noticed your image URLs are sometimes wrong. it needs to be ../assets not /assets/

mfb avatar Feb 25 '16 07:02 mfb

@mfb I think all of these are wrong and they need to be "assets/". For some reason relative paths seems to work? Images also apparently need to be ng-src="" and not src="" if there's a {{data.actionItem.image}} type variable inside otherwise it will make two calls -- one first to literally http://url/%7B%7Bdata.actionItem.image%7B%7B before grabbing the correct one.

jpt avatar Feb 25 '16 22:02 jpt