EDMarketConnector icon indicating copy to clipboard operation
EDMarketConnector copied to clipboard

Ensure the Windows build process always includes all necessary files

Open Athanasius opened this issue 3 years ago • 0 comments

Currently we have a hardcoded list of 'components' (one per file) in EDMarketConnector.wxs.

If either a new Python release includes a new file (which can include, e.g. internationalistion files), or a change in our code causes py2exe to pull in extra file(s) then we need to ensure we're packaging them into the Windows installer.

Possible issues:

  • [ ] We have some hard-coded GUIDs on some components, for historic reasons. We'd need to either preserve these, or have a 'flag day' release where users must uninstall/install new to be sure it works correctly. This assumes that the use of 'Major Upgrade' in the WiX configuration doesn't make this moot.
  • [ ] We would need to build the .wxs file from:
    1. a header of hard-coded config
    2. a middle of auto-generated components (using WiX heat.exe)
    3. a tail of to properly close the file To address the "some hard-coded GUIDs" I'm hoping heat.exe can take an input reference file....

NB: This process would, of course, be run after the py2exe invocation creates dist.win32, so what's present inside there is the reference for it.

Athanasius avatar Dec 06 '21 15:12 Athanasius