EDMarketConnector
EDMarketConnector copied to clipboard
Handle CAPI Too Many Requests
Currently we just splat an error when we get a 429 from CAPI:
2021-10-25 20:00:00.346 - ERROR - 505944:520528:520528 companion.capi_single_query:771: Frontier CAPI Auth: GET /shipyard
Traceback (most recent call last):
File "companion.pyc", line 755, in capi_single_query
File "requests\models.pyc", line 953, in raise_for_status
requests.exceptions.HTTPError: 429 Client Error: Too Many Requests for url: https://companion.orerve.net/shipyard
2021-10-25 20:00:00.347 - ERROR - 505944:520528:520528 companion.Session.dump:1007: Frontier CAPI Auth: https://companion.orerve.net/shipyard 429 Too Many Requests
2021-10-25 20:00:00.348 - ERROR - 505944:520528:520528 companion.capi_single_query:783: Frontier CAPI: Misc. Error
Traceback (most recent call last):
File "companion.pyc", line 755, in capi_single_query
File "requests\models.pyc", line 953, in raise_for_status
requests.exceptions.HTTPError: 429 Client Error: Too Many Requests for url: https://companion.orerve.net/shipyard
2021-10-25 20:00:00.353 - DEBUG - 505944:523248:523248 EDMarketConnector.AppWindow.capi_handle_response:1193: "other" exception
Traceback (most recent call last):
File "companion.pyc", line 755, in capi_single_query
File "requests\models.pyc", line 953, in raise_for_status
requests.exceptions.HTTPError: 429 Client Error: Too Many Requests for url: https://companion.orerve.net/shipyard
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "EDMarketConnector.py", line 1016, in capi_handle_response
File "companion.pyc", line 896, in capi_query_worker
File "companion.pyc", line 869, in capi_station_queries
File "companion.pyc", line 784, in capi_single_query
companion.ServerError: Frontier CAPI: Misc. Error
I think it'd be better to:
- Double the timeout for the next pull
- Show an error message to the user informing them that:
- We got a too many requests
- This usually happens when more than one thing is doing CAPI
- They should either close us or something else thats doing CAPI