EDMarketConnector icon indicating copy to clipboard operation
EDMarketConnector copied to clipboard

util_ships.py:ship_file_name() could use `pathlib.PureWindowsPath.is_reserved()`

Open Athanasius opened this issue 3 years ago • 2 comments

Rather than trying to maintain a list of 'reserved' file names ourselves.

Athanasius avatar Aug 31 '21 09:08 Athanasius

note that is_reserved is available on Path itself as well, which would be even cleaner than going directly to PureWindowsPath and would mean no need to a platform guard

A-UNDERSCORE-D avatar Aug 31 '21 10:08 A-UNDERSCORE-D

close != comment. Whoops.

A-UNDERSCORE-D avatar Aug 31 '21 10:08 A-UNDERSCORE-D