EDMarketConnector icon indicating copy to clipboard operation
EDMarketConnector copied to clipboard

System doesnt tell you if it has been discovered or not

Open FunkyPixie opened this issue 4 years ago • 18 comments

I remember in the old version of ED:MC that if you were in a already discovered system it would have a green dot and if you were in a newly discovered system it would have a yellow star, Now it doesnt show anything next to the system name when you arrive in it, Yes I'm connected to EDSM and INARA

FunkyPixie avatar May 24 '21 15:05 FunkyPixie

Are you sure that EDSM has data for the system(s) in question?

I'm in Unktety right now and it has the Green circle showing.

Athanasius avatar May 24 '21 15:05 Athanasius

Although according to the docs I wrote, you should see something there https://github.com/EDCD/EDMarketConnector/wiki#system-name

  • Whether you use EDSM as the provider or not you might see an extra image at the end of the System name:
    1. <Green Circle> - This system is known to EDSM, including co-ordinates.
    2. <Red Circle> - This system is not known to EDSM.
    3. <Yellow Star> - You were the first to report this system to EDSM.
    4. <?> - An error occurred checking the status of the system on EDSM.

We'll need a debug log file (as the Bug Report template would have asked for if you'd used it, like you should have) to investigate further, and possibly a related Journal file as well.

Athanasius avatar May 24 '21 15:05 Athanasius

o,,,,k that was weird i restarted ED:MC and now it shows the green dot that was strange

FunkyPixie avatar May 24 '21 15:05 FunkyPixie

o,,,,k that was weird i restarted ED:MC and now it shows the green dot that was strange

It's possible that the EDSM plugin code errored out and stopped responding for this bit of the UI. If it happens again then DO NOT CLOSE EDMC, but straight away upload a copy of the plain log file here (just drag and drop it into a new comment).

That way we can determine if such a bug does exist, and if so, fix it.

Athanasius avatar May 24 '21 16:05 Athanasius

Ok

FunkyPixie avatar May 24 '21 16:05 FunkyPixie

ok somthing i have noticed is that when you start elite with the market connector on standing in a station (not on the ship) it doesnt show the green dot and when you get onto the ship the green dot still doesnt show up EDMarketConnector-debug.log

FunkyPixie avatar May 25 '21 16:05 FunkyPixie

EDMarketConnector_Qf4pO1x1Gf

FunkyPixie avatar May 25 '21 16:05 FunkyPixie

ok somthing i have noticed is that when you start elite with the market connector on standing in a station (not on the ship) it doesnt show the green dot and when you get onto the ship the green dot still doesnt show up EDMarketConnector-debug.log

That might be expected, with how the code currently is. If you start EDMC after the game is already running then it only does minimal processing of the Journal, to set some internal state, not the full processing as it does with 'live' events after that.

But we'll check into it. We might be able to improve that.

Athanasius avatar May 25 '21 16:05 Athanasius

ok

FunkyPixie avatar May 25 '21 17:05 FunkyPixie

In this specific case the whole "does EDSM know about this" is implemented in the EDSM plugin (which is part of the core code in the sense that we maintain it, but is technically a plugin and treated the same as any third-party plugin in all ways).

I think we avoid sending all the 'catch up' journal events to plugins on startup so as to not spam third-party services with data, which is also probably redundant given you might have restarted EDMC and thus all that data was already sent.

The "Display EDSM status of this system" functionality very much relies on the plugin being handed the data so it will be... difficult... to change this behaviour.

Athanasius avatar May 25 '21 17:05 Athanasius

hmm ok

I loaded up ED:MC first and then elite just now and i still get the no green dot.... let me try to jump to another system and see what happens EDMarketConnector-debug.log

FunkyPixie avatar May 25 '21 17:05 FunkyPixie

nope nothing

FunkyPixie avatar May 25 '21 17:05 FunkyPixie

hmm quiting to main menu and rejoining seems to show the green dot (when your floating in space)

FunkyPixie avatar May 25 '21 17:05 FunkyPixie

Hey there @FunkyPixie. Triaging issues and found this one. Sorry it's been a while since anyone responded to you!

Is this issue still ongoing?

Rixxan avatar Aug 24 '23 13:08 Rixxan

Hey there @FunkyPixie. Triaging issues and found this one. Sorry it's been a while since anyone responded to you!

Is this issue still ongoing?

hello yes… this issue still happens. although it seems to happen when you start EDMC while you are on foot in odyssey. if you start EDMC while in a ship this bug doesn’t happen

FunkyPixie avatar Aug 24 '23 13:08 FunkyPixie

Hmm. I'm not currently able to replicate this. As I understand it, this only happens when you're on foot. (Currently wandering around Jameson Memorial's concourse)

Attempted:

  1. Launch Elite from Desktop, with EDMC running
  2. Launch Elite from Desktop, then start EDMC
  3. Load in to game from menu with EDMC startup while on Elite's main menu
  4. Relog in game with EDMC running the whole time (log in, log out, log in again)

If you are able to reliably replicate this issue, please let me know how you've done it so I can continue debugging this issue.

Rixxan avatar Apr 27 '24 20:04 Rixxan