EDDI icon indicating copy to clipboard operation
EDDI copied to clipboard

the properties of the celestial bodies are not read out correctly

Open nepomuk16321 opened this issue 4 months ago • 10 comments

What's Wrong (please be as specific as possible)

Expected

Correct reading of the properties, if a loop is used for reading, the property is only recognised or output correctly on the second pass

Observed

Body properties are not recognised correctly, e.g. "body.alreadydiscovered" for newly discovered systems

Steps to reproduce

see text below

Configuration

  • Version [Please give full version numbers here, not just "latest" or "current"]
    • EDDI Version: v.4.1.0-b3
    • VoiceAttack Version: not used
  • Localization [if applicable]
    • EDDI's language: German
    • Voice: Petra Harpo 22kHz

My Investigation

Investigation Notes

see text below

EDDI Logs

eddi.log

Player journals

Journal.2024-10-18T150918.01.log

Hello everyone, I think EDDI has a problem recognising the properties of the celestial bodies correctly? How do I arrive at this assertion? I am currently outside the bubble to discover a few undiscovered systems. It was while doing this that I noticed something. Once you have found an undiscovered system (sun with the property ‘body.alreadydiscovered = false’), you scan the bodies of the system (planets and moons) with the VSS/FSS. If you use a loop to query the property of whether the body has already been discovered (to recognise undiscovered bodies), you will be told on the first run that all bodies have been discovered, except one. If you run the query a second time, the bodies are correctly displayed/announced as not yet discovered. (Loop, which I have used, see at the end). The entries in the journal are correct. The bodies are listed as ‘WasDiscovered:false’. It is now difficult for a second CMDR to understand this, as the system has already been discovered by me. But wait, I haven't submitted the data yet, so a second CMDR would be able to check this. Here is the system where I noticed this: Pyult ZZ-E c28-2 . Only the last planet (planet 5) is announced as ‘unknown’ on the first run, the other 4 planets are announced as ‘known’ on the first run. Perhaps this error also has to do with not recognising the second or third sun, which I already described in the last thread. The second run of the FSSDiscoveryScan recognises the second or third sun.

Recognition loop:

{for body in SystemDetails(system.systemname).bodies:
    {body.shortname}
    {set bodies to bodies + 1}
    {if body.bodytype = "Mond" || body.bodytype = "Planet": 
        {if body.alreadydiscovered: bekannt, {set alreadydiscovered to alreadydiscovered + 1}
        |elif !body.alreadydiscovered: unbekannt, {set nondiscovered to nondiscovered + 1} }
    }
	{if body.bodytype = "Stern":
        {set body_stern to body_stern + 1} 
        {if body.alreadydiscovered = true : {_ system bekannt }
		|else: System ist unbekannt}
	}
}
Körper = {bodies},
Sterne = {body_stern},
bekannte Objekte = {if alreadydiscovered = 0 || !alreadydiscovered: 0: |else: {alreadydiscovered} }
unbekannte Körper = {if nondiscovered = 0 || !nondiscovered: 0: |else: {nondiscovered} }

nepomuk16321 avatar Oct 18 '24 19:10 nepomuk16321