Cabana icon indicating copy to clipboard operation
Cabana copied to clipboard

Adds linked cell parallel capability

Open lebuller opened this issue 2 years ago • 3 comments

lebuller avatar Nov 07 '23 14:11 lebuller

Codecov Report

Attention: Patch coverage is 95.74468% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 96.5%. Comparing base (dcaa181) to head (6525c20). Report is 59 commits behind head on master.

:exclamation: Current head 6525c20 differs from pull request most recent head 96a0bc1. Consider uploading reports for the commit 96a0bc1 to get more accurate results

Files Patch % Lines
core/src/Cabana_LinkedCellList.hpp 93.2% 5 Missing :warning:
core/src/Cabana_Parallel.hpp 97.9% 2 Missing :warning:
core/src/Cabana_NeighborList.hpp 83.3% 1 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #712    +/-   ##
=======================================
  Coverage    96.4%   96.5%            
=======================================
  Files          90      92     +2     
  Lines       14498   14849   +351     
=======================================
+ Hits        13989   14332   +343     
- Misses        509     517     +8     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 15 '23 21:11 codecov[bot]

Initial performance check on Frontier (with Verlet results for comparison) linkedcell verlet

Note that the results marked neighbor here are NOT exposed to the user directly (could still be done with a linear Kokkos parallel loop and direct neighbor interface usage) and the results marked iterate use the new custom neighbor_parallel_for restricted to LinkedCellLists

streeve avatar Nov 28 '23 16:11 streeve

CI timeouts unrelated (and manually tested on HIP)

streeve avatar Nov 28 '23 18:11 streeve

Final performance comparisons from Frontier - no significant changes from previous results lcl_performance_frontier verlet_performance_frontier

streeve avatar May 02 '24 22:05 streeve

Test failures unrelated (docker, jenkins, coverage)

streeve avatar May 03 '24 16:05 streeve