Cabana icon indicating copy to clipboard operation
Cabana copied to clipboard

Add HIP support for HYPRE

Open abisner opened this issue 2 years ago • 5 comments

~Added FindHYPRE cmake for autotools install in lieu of available CMake installation.~

Uses pkgconfig instead in lieu of available CMake installation

abisner avatar Aug 03 '23 13:08 abisner

This PR adds a FindHYPRE cmake to be used in the case of Kokkos HIP builds, in which there is currently no supported CMake installation method for hypre builds on AMD.

abisner avatar Aug 03 '23 13:08 abisner

Okay @junghans failure here is finally just missing the right target "pkgconfig:PC_HYPRE" does not already exist.

streeve avatar Sep 15 '23 21:09 streeve

@junghans I tried some more in a container, but I don't see any pkg-config content from hypre anywhere.. If we point to that correctly I think it will finally work

streeve avatar Sep 18 '23 21:09 streeve

Now blocked by #697

streeve avatar Oct 05 '23 16:10 streeve

Should be able to close/replace once https://github.com/hypre-space/hypre/tree/cmake-hip is merged @victorapm

streeve avatar Oct 08 '24 18:10 streeve

Should be able to close/replace once https://github.com/hypre-space/hypre/tree/cmake-hip is merged @victorapm

This was merged, so let's close.

junghans avatar Sep 18 '25 20:09 junghans

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 96.5%. Comparing base (fa9e58a) to head (45b7be6). :warning: Report is 242 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #658   +/-   ##
======================================
  Coverage    96.5%   96.5%           
======================================
  Files          89      89           
  Lines       15321   15321           
======================================
  Hits        14790   14790           
  Misses        531     531           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Sep 18 '25 20:09 codecov[bot]