Cabana icon indicating copy to clipboard operation
Cabana copied to clipboard

Add particle list with field tags

Open streeve opened this issue 3 years ago • 2 comments

Wraps the AoSoA with more user friendly type tags and enables a thread-level particle interface. Adapted from Picasso

Currently single AoSoA only, with a separate version in Cajita that stores the mesh as well.

Should add an example before merging

streeve avatar Jul 14 '22 14:07 streeve

Codecov Report

Merging #556 (030eec2) into master (249689a) will decrease coverage by 0.2%. The diff coverage is 100.0%.

:exclamation: Current head 030eec2 differs from pull request most recent head 1780fc1. Consider uploading reports for the commit 1780fc1 to get more accurate results

@@           Coverage Diff            @@
##           master    #556     +/-   ##
========================================
- Coverage    95.0%   94.7%   -0.3%     
========================================
  Files          47      48      +1     
  Lines        5733    5542    -191     
========================================
- Hits         5449    5251    -198     
- Misses        284     291      +7     
Impacted Files Coverage Δ
core/src/Cabana_Fields.hpp 100.0% <100.0%> (ø)
core/src/Cabana_ParticleList.hpp 100.0% <100.0%> (ø)
cajita/src/Cajita_ReferenceStructuredSolver.hpp 96.5% <0.0%> (-1.8%) :arrow_down:
cajita/src/Cajita_Array.hpp 94.6% <0.0%> (-1.6%) :arrow_down:
core/src/Cabana_Sort.hpp 99.0% <0.0%> (-1.0%) :arrow_down:
core/src/Cabana_Distributor.hpp 94.4% <0.0%> (-0.7%) :arrow_down:
cajita/src/Cajita_SparseLocalGrid_impl.hpp 90.9% <0.0%> (-0.2%) :arrow_down:
core/src/Cabana_VerletList.hpp 99.5% <0.0%> (-0.1%) :arrow_down:
core/src/Cabana_Tuple.hpp 100.0% <0.0%> (ø)
cajita/src/Cajita_Parallel.hpp 100.0% <0.0%> (ø)
... and 7 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jul 14 '22 17:07 codecov[bot]

@sslattery renamed functions, cleaned up history, and removed the internal comm rank field like you previously suggested (kept the position for convenience in the Cajita::ParticleList)

Tested with HIP manually

streeve avatar Oct 14 '22 18:10 streeve