impactx icon indicating copy to clipboard operation
impactx copied to clipboard

[WIP] Dashboard: add input error tracking

Open proy30 opened this issue 6 months ago • 0 comments

This PR provides the user guidance on which inputs are invalid. Additionally, the PR refactors the current logic to track such errors.

Changes:

  • A new dynamic notification banner in the Inputs toolbar which will display the count of input errors the user has. Hovering over the banner will tell the user exactly which inputs are incorrect along with the error message.
  • A new class, SimulationValidation in validation.py, is created to encapsulate all logic for determining whether the simulation can run based on current input errors.
  • The primary method in the class, update, takes the input section header as an argument.
    • This allows the method to check only the relevant section for errors.
  • Add a JS function to suppress resizeWarning error.
    • Does not affect the dashboard functionality.
  • Remove unhelpful (and unneeded) comments in generalFunctions.py
  • Fix variable naming in shared.py
    • A variable referring to csr inputs was incorrectly labeled under space charge

Demo:

https://github.com/user-attachments/assets/b921e68d-f1a6-45af-b15c-6b23fc592152

Merge after https://github.com/BLAST-ImpactX/impactx/pull/981

proy30 avatar Jun 10 '25 00:06 proy30