impactx
impactx copied to clipboard
Missing dashboard CI testing for Windows/Tooling workflows
PR #955 successfully runs and tests the dashboard on the following workflows: macOS, Ubuntu, and Stubs. However, the Windows and Tooling workflows fail. This is likely due to dependency issues, rather than the dashboard itself.
From initial testing, the following is what I encountered:
Windows workflow:
From running the following in Clang w/ OMP w/o MPI after Builld:
- name: Install ImpactX Python binding
shell: cmd
run: |
call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\vc\Auxiliary\build\vcvarsall.bat" x64
cmake --build build --config Release --target pip_install
- name: Run dashboard tests
shell: cmd
run: |
call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\vc\Auxiliary\build\vcvarsall.bat" x64
cd tests/python/dashboard
pytest --confcutdir=.
The Install ImpactX Python binding passes but the Run dashboard tests fails with the following:
Waiting for dashboard server to start - 14s elapsed.
File "C:\hostedtoolcache\windows\Python\3.13.3\x64\Lib\site-packages\impactx\__init__.py", line 20, in <module>
Waiting for dashboard server to start - 15s elapsed.
from . import impactx_pybind as cxx
Waiting for dashboard server to start - 16s elapsed.
ImportError: DLL load failed while importing impactx_pybind: The specified module could not be found.
Waiting for dashboard server to start - 17s elapsed.
Waiting for dashboard server to start - 18s elapsed.
Waiting for dashboard server to start - 19s elapsed.
Tooling workflow:
From running cmake --build build --target pip_install after build ImpactX the following happens:
cd /home/runner/work/impactx/impactx/build/_deps/fetchedpyamrex-build && /usr/bin/ccache /usr/bin/mpic++ -I/home/runner/work/impactx/impactx/build/_deps/fetchedamrex-src/Tools/C_scripts -Werror -Wno-error=pass-failed -fsanitize=address,undefined -shared-libsan -Wall -Wextra -Wpedantic -Wshadow -Woverloaded-virtual -Wextra-semi -Wunreachable-code -O2 -g -DNDEBUG -std=c++17 -fPIC -MD -MT _deps/fetchedpyamrex-build/CMakeFiles/buildInfopyAMReX_3d.dir/pyAMReX_3d/AMReX_buildInfo.cpp.o -MF CMakeFiles/buildInfopyAMReX_3d.dir/pyAMReX_3d/AMReX_buildInfo.cpp.o.d -o CMakeFiles/buildInfopyAMReX_3d.dir/pyAMReX_3d/AMReX_buildInfo.cpp.o -c /home/runner/work/impactx/impactx/build/_deps/fetchedpyamrex-build/pyAMReX_3d/AMReX_buildInfo.cpp
g++: error: unrecognized command-line option ‘-shared-libsan’; did you mean ‘-shared-libgcc’?
gmake[3]: *** [_deps/fetchedpyamrex-build/CMakeFiles/buildInfopyAMReX_3d.dir/build.make:82: _deps/fetchedpyamrex-build/CMakeFiles/buildInfopyAMReX_3d.dir/pyAMReX_3d/AMReX_buildInfo.cpp.o] Error 1
gmake[3]: Leaving directory '/home/runner/work/impactx/impactx/build'
gmake[2]: *** [CMakeFiles/Makefile2:2527: _deps/fetchedpyamrex-build/CMakeFiles/buildInfopyAMReX_3d.dir/all] Error 2
gmake[2]: Leaving directory '/home/runner/work/impactx/impactx/build'
gmake[1]: *** [CMakeFiles/Makefile2:2303: CMakeFiles/pip_install.dir/rule] Error 2
gmake[1]: Leaving directory '/home/runner/work/impactx/impactx/build'
gmake: *** [Makefile:624: pip_install] Error 2