impactx icon indicating copy to clipboard operation
impactx copied to clipboard

Dashboard: update python parser

Open proy30 opened this issue 3 months ago • 5 comments

A branch that was worked on primarily during the summer months.

In cleanup processes now..

  • [X] Support a wider range of impactX examples
  • [X] Add test_lattice_stats
    • By adding this test file, we test both the lattice statistics and indirectly the updated python parser. The statistics will reflect what the parser inputs into the dashboard.
  • [X] Support sim.lattice.append()
  • [X] Support sim.lattice.extend()
  • [X] Support sim.lattice.reverse()

_Note: As we rely on regex for the parser, it is "breakable", depending on the type of input files structures it receives. However, it is important to note that any of the impactX examples inside of the dashboard is completely supported by the parser.

proy30 avatar Sep 15 '25 17:09 proy30

Hi @cemitch99 , would you please be able to try again? I was unable to replicate my environment as yours, so I am not fully positive if the solution is now fixed or not.

proy30 avatar Sep 25 '25 15:09 proy30

Hi @proy30 . Thanks for the recent changes! I tried again, using impactx-dashboard, and I see the same error. A similar error appears if I launch within Jupyter. There could be an issue that is unique to my environment.

However, if I launch the dashboard using python -m dashboard within src/python/impactx, then everything works perfectly.

cemitch99 avatar Sep 25 '25 17:09 cemitch99

@cemitch99 Thank you for letting me know. I have to investigate the issue further and will update again.

proy30 avatar Sep 25 '25 20:09 proy30

Fix in #1179

ax3l avatar Oct 13 '25 23:10 ax3l

@proy30 let me know when you are ready for me to review the updates discussed above :) :pray:

ax3l avatar Nov 10 '25 19:11 ax3l

@proy30 let me know when you are ready for me to review the updates discussed above :) 🙏

ax3l avatar Dec 02 '25 17:12 ax3l

@ax3l Just now seeing the ping, this is completed now once tests pass 🙏

proy30 avatar Dec 04 '25 04:12 proy30