WarpX icon indicating copy to clipboard operation
WarpX copied to clipboard

[WIP] Rename Efield/Bfield to E/B

Open RemiLehe opened this issue 1 year ago • 1 comments

This makes names shorter and more consistent.

This is a breaking change for Python users that access he E- and B-field directly by name. Was, e.g.,:

.multifab("Efield_fp", ...)

is now:

.multifab("E_fp", ...)

For:

  • Efield_...
  • Bfield_...
  • .._fp, ..._cp, ..._aux, ..._cax, ..._fp_external, ..._avg_fp, ..._avg_cp

RemiLehe avatar Sep 24 '24 13:09 RemiLehe

@RemiLehe this needs a small update for merge conflicts please :)

In tests, it looks like only test_2d_embedded_circle.run is failing right now with

STEP 11 starts ...
terminate called after throwing an instance of 'std::runtime_error'
  what():  Assertion `flo * fhi <= T(0)' failed, file "/home/vsts/work/1/s/build/_deps/fetchedamrex-src/Src/Base/AMReX_Algorithm.H", line 116, Msg: "Error - calling bisect but lo and hi don't bracket a root."
SIGABRT

ax3l avatar Sep 25 '24 16:09 ax3l