WarpX icon indicating copy to clipboard operation
WarpX copied to clipboard

[WIP] Adding Higginson's correction and a test for the Coulomb collision module

Open Yin-YinjianZhao opened this issue 2 years ago • 3 comments

We try to add a test that the simulation result should match better with an analytical solution for the Coulomb collision module. The test is described by Smilei (3. Temperature isotropization, Fig 18.): https://smileipic.github.io/Smilei/Understand/collisions.html#test-cases-for-collisions Their scripts can be found here: https://smileipic.github.io/tutorials/advanced_collisions.html https://github.com/SmileiPIC/Smilei/tree/master/benchmarks/collisions

When implementing the test, we found our Coulomb module has a bug that occurs among collisions within a single species, which should be related to Higginson's correction: https://www.sciencedirect.com/science/article/pii/S0021999120302242?via%3Dihub

Thus, we will add Higginson's correction and that test in this PR.

Yin-YinjianZhao avatar Nov 01 '22 16:11 Yin-YinjianZhao

So far, this version of the PR still has some issues, the results do not match that well. Smilei's plot: Screen Shot 2022-10-24 at 10 11 38 AM Ours: Screen Shot 2022-11-01 at 10 19 24 AM

Yin-YinjianZhao avatar Nov 01 '22 17:11 Yin-YinjianZhao

@Yin-YinjianZhao @RemiLehe Would you be able to point to the lines in the Smilei code where the Higginson correction is implemented? Is it supposed to be found somewhere in their file Collisions/BinaryProcesses.cpp?

EZoni avatar Nov 10 '22 19:11 EZoni

Yes, the intra-species correction can be found here: https://github.com/SmileiPIC/Smilei/blob/master/src/Collisions/BinaryProcesses.cpp#L304 More broadly, the Higginson scheme itself is implemented throughout this file so it is difficult to point a specific line.

RemiLehe avatar Nov 10 '22 21:11 RemiLehe

Superseded by https://github.com/ECP-WarpX/WarpX/pull/5091

RemiLehe avatar Jul 29 '24 19:07 RemiLehe