ols4 icon indicating copy to clipboard operation
ols4 copied to clipboard

OLS4 does not provice baseUris for GO

Open afg1 opened this issue 2 years ago • 4 comments

Describe the bug We have a pipeline which looks at the following endpoint: https://www.ebi.ac.uk/ols4/api/ontologies/GO

Comparing this to the OLS3 version (https://www.ebi.ac.uk/ols/api/ontologies/GO), the baseUris entry under the config is now empty, causing our pipeline to crash.

To Reproduce

  1. run curl https://www.ebi.ac.uk/ols/api/ontologies/GO
  2. run curl https://www.ebi.ac.uk/ols4/api/ontologies/GO
  3. compare the entries in ['config']['baseUris']

Expected behavior I expected the baseUris to be in the same place, but they don't appear to be anywhere in the returned JSON from OLS4

A quick check with some other ontologies (SO, UBERON, EFO) shows this is not across the board - SO and UBERON show the same problem as GO, but EFO has baseUris in the place I expected

afg1 avatar Oct 17 '23 12:10 afg1

There is no clear definition of what a baseUri is to be able to deterministically derive it. This is best implemented as a configuration, ideally in OBO. @udp is following up have this included in the OBO config.

henrietteharmse avatar Nov 06 '23 13:11 henrietteharmse

@henrietteharmse this seems to be a breaking change. I am unable to get baseUris for duo, ncit and few more.

I have been using double encoded baseUri + code to fetch ancestors and descendents of terms in one of my tools.

Is this something that is being fixed, or do you suggest another approach? @afg1 how did you patch this at your end?

Thanks :)

anuradhawick avatar Nov 27 '23 05:11 anuradhawick

@udp may I ask if you plan to fix this for other ontologies too (ncit, obo, obi, genepio, etc)? I could not find a way around because I need to use the double encoded IRI.

Thanks

anuradhawick avatar Nov 27 '23 06:11 anuradhawick

@anuradhawick Sorry for the slow reply!

I just hardcoded what we needed to get a release out, it was a bit of a hack:

 manual_lookup = {
    "ECO": "http://purl.obolibrary.org/obo/ECO_",
    "GO": "http://purl.obolibrary.org/obo/GO_",
    "SO": "http://purl.obolibrary.org/obo/SO_",
}

Probably doesn't help you, sorry. This got us through the release process, but is on our to-do list to remove when the baseUris are available via OLS4.

afg1 avatar Dec 11 '23 16:12 afg1