goci
goci copied to clipboard
Search UI page loading issues - detail pages
Detail pages in the UI have problems loading (especially in Chrome) due to data volume. This due to inefficient pagination.
An acceptable solution for the details pages would be to identify a cutoff that can be loaded successfully. Beyond this, the table would appear with a message something like "Warning: only the first 2000 rows could be displayed" and an option to download the data in a text file.
This would enable us to keep all the search/sort features of the tables.
ideally the association data should be loaded pre-sorted by p value, with the most significant association first, as this probably the most common use cases for the search/sort features. Users can then access the most significant associations even if the data is capped.
Here are examples of some pages that do not load in Chrome: https://www.ebi.ac.uk/gwas/publications/32888494 https://www.ebi.ac.uk/gwas/publications/30595370 https://www.ebi.ac.uk/gwas/efotraits/EFO_0004612
This one does load with 10,498 associations: https://www.ebi.ac.uk/gwas/publications/33462484
Note there may be a separate issue for loading trait pages with many child terms, e.g. https://www.ebi.ac.uk/gwas/efotraits/EFO_0000311 which never loads even in Firefox. This may be out of scope to fix for now if it's more complicated.
@ljwh2 it seems these are solved now with the immediate solution proposed, someone can help confirm in snoopy
http://gwas-snoopy.ebi.ac.uk:9780/gwas/publications/32888494 http://gwas-snoopy.ebi.ac.uk:9780/gwas/publications/30595370 http://gwas-snoopy.ebi.ac.uk:9780/gwas/publications/30595370
http://gwas-snoopy.ebi.ac.uk:9780/gwas/publications/33462484
These are not loading for me in Snoopy after 5 mins
This looks good to me now for the examples, one small thing the text should read "download catalog data button"
This works for associations but I tested for a publication with >5K studies, only 5K rows are displayed but no message is shown: http://gwas-snoopy.ebi.ac.uk:9780/gwas/publications/34662886
@sprintell I think this can be closed but I would first like to confirm whether the association data is pre-sorted by p value
Association data should be loaded pre-sorted by p value,
not complete but will be fixed in new UI framework