goci icon indicating copy to clipboard operation
goci copied to clipboard

Implement process to detect and update obsoleted EFO terms prior to data release

Open ljwh2 opened this issue 3 years ago • 3 comments

EFO sometimes obsoletes terms and replaces them with new ones. When obsolete terms have been used in the GWAS Catalog and not updated, this causes the data release to fail.

We need a process to to detect and update obsolete terms to be run prior to data release.

EFO release notes are here: https://github.com/EBISPOT/efo/blob/master/ExFactor%20Ontology%20release%20notes.txt

See also these tickets: gwas-utils#15 goci#366 (wider issue of propogating changes in EFO eg term name, definition, to the GWAS catalog, not required now but we should plan for this in the future)

ljwh2 avatar Jan 06 '22 11:01 ljwh2

@ala-ebi is this the same issue that you recently fixed?

ljwh2 avatar Aug 24 '22 08:08 ljwh2

@ljwh2 No, the one that was recently fixed involves ignoring EFOs that have no parent that is defined within our system when generation the EFO Mappings file

ala-ebi avatar Aug 24 '22 08:08 ala-ebi

Obsolete terms now seem to persist in the Catalog with "obsolete_" in the trait name e.g. https://www.ebi.ac.uk/gwas/efotraits/EFO_0000311 We need a process to catch these and update them

Separate ticket for this issue

ljwh2 avatar Nov 16 '22 13:11 ljwh2

1- we will check if other teams have processes in place to detect and update obsolete terms 2- we will check with EFO team if they can provide and standardised format for what has changed 3- we will crawl the .owl file and see if any obsoleted terms (using the 'obsolete' tag) exist in the catalog and replace them with new term

ala-ebi avatar May 17 '23 10:05 ala-ebi

@ala-ebi it would be useful to include James M in any discussion with the EFO team

ljwh2 avatar May 17 '23 12:05 ljwh2

https://www.ebi.ac.uk/gxa/home is using EFO but not sure who the contact person is. Daniel Suveges would be a good place to start for Open Targets. Also HCA, Tony Burdett

ljwh2 avatar May 17 '23 13:05 ljwh2

Irene Lopez is the right person for Open Targets

ljwh2 avatar May 18 '23 12:05 ljwh2

use mongo DB instead send emails to curators as well

ala-ebi avatar Jun 14 '23 10:06 ala-ebi

waiting for automated deployment @ala-ebi

sprintell avatar Sep 06 '23 09:09 sprintell