goci icon indicating copy to clipboard operation
goci copied to clipboard

Fix folders on staging for GCSTs without sumstats

Open karatugo opened this issue 10 months ago • 12 comments

✅ There seem to be folders being created on staging for GCSTs which do not have sumstats. Previously, folders were only created on staging for those GCSTs with full p-value set ticked (i.e. have sumstats) - eg. GCST90321079, GCST90310292, GCST90397904

karatugo avatar Apr 29 '24 10:04 karatugo

Couldn't reproduce the issue on sandbox. Perhaps it was fixed by https://app.zenhub.com/workspaces/gwas-59df823c4a6feb3786810391/issues/gh/ebispot/goci/1292

karatugo avatar Apr 29 '24 13:04 karatugo

Test with GCST90428125-GCST90428269 and GCST90428282-GCST90428285

karatugo avatar Apr 29 '24 13:04 karatugo

I'm able to reproduce this issue now. The trick is to update traits and force new metadata yaml generation.

karatugo avatar Apr 29 '24 15:04 karatugo

Should be fixed now.

karatugo avatar Apr 29 '24 16:04 karatugo

Please clean te empty folders created by the bug. @karatugo

sprintell avatar May 01 '24 09:05 sprintell

Can't find empty dirs other than GCST90102485. Perhaps my script at /hps/nobackup/parkinso/spot/gwas/scratch/goci1306 is wrong?

karatugo avatar May 02 '24 17:05 karatugo

@earlEBI Could you please verify that the folders without sumstats are deleted or contain their files now?

karatugo avatar May 02 '24 17:05 karatugo

@earlEBI please confirm when you are back, thanks

ljwh2 avatar May 08 '24 09:05 ljwh2

The three directories I gave as examples still exist on staging, empty. These studies do not have sumstats.

earlEBI avatar May 13 '24 14:05 earlEBI

Okay, my script was wrong: https://app.zenhub.com/workspaces/gwas-59df823c4a6feb3786810391/issues/gh/ebispot/goci/1306#issuecomment-2091113483

For some weird reason, I was checking the public ftp.

karatugo avatar May 13 '24 16:05 karatugo

Now submitted a new SLURM job that checks the staging FTP.

karatugo avatar May 13 '24 16:05 karatugo

@earlEBI Sorry for the misunderstanding, should be fixed now.

karatugo avatar May 14 '24 10:05 karatugo

I confirm the original empty directories I listed are now removed from staging.

earlEBI avatar May 15 '24 08:05 earlEBI