goci
goci copied to clipboard
Fix folders on staging for GCSTs without sumstats
✅ There seem to be folders being created on staging for GCSTs which do not have sumstats. Previously, folders were only created on staging for those GCSTs with full p-value set ticked (i.e. have sumstats) - eg. GCST90321079, GCST90310292, GCST90397904
Couldn't reproduce the issue on sandbox. Perhaps it was fixed by https://app.zenhub.com/workspaces/gwas-59df823c4a6feb3786810391/issues/gh/ebispot/goci/1292
Test with GCST90428125-GCST90428269 and GCST90428282-GCST90428285
I'm able to reproduce this issue now. The trick is to update traits and force new metadata yaml generation.
Should be fixed now.
Please clean te empty folders created by the bug. @karatugo
Can't find empty dirs other than GCST90102485
. Perhaps my script at /hps/nobackup/parkinso/spot/gwas/scratch/goci1306
is wrong?
@earlEBI Could you please verify that the folders without sumstats are deleted or contain their files now?
@earlEBI please confirm when you are back, thanks
The three directories I gave as examples still exist on staging, empty. These studies do not have sumstats.
Okay, my script was wrong: https://app.zenhub.com/workspaces/gwas-59df823c4a6feb3786810391/issues/gh/ebispot/goci/1306#issuecomment-2091113483
For some weird reason, I was checking the public ftp.
Now submitted a new SLURM job that checks the staging FTP.
@earlEBI Sorry for the misunderstanding, should be fixed now.
I confirm the original empty directories I listed are now removed from staging.