goci icon indicating copy to clipboard operation
goci copied to clipboard

Minor allele frequency lower limit is not getting validated in the metadata template

Open ljwh2 opened this issue 1 year ago • 7 comments

Some recent submissions produced a celery error for MAF lower limit (value is not a float). The value was entered as a % in the template, whereas only a decimal value is allowed. This should not pass validation.

The submissions are: https://www.ebi.ac.uk/gwas/deposition/submission/64d6ba9553c4ef0001f007ee

traceback call for the other is: Task was called with args: [{'callbackID': 'UPciAwBx', 'studyList': [{'id': '64da3de0788f0000010e5d50', 'gcst': 'GCST90277450', 'pmid': None, 'file_path': 'ac_impall_LifetimeMDD.tsv', 'assembly': 'GRCh38', 'callback_id': 'UPciAwBx', 'readme': None, 'entryUUID': '70ef7d1b-4ef7-4846-bfdc-c3153f9c2522', 'author_name': None, 'rawSS': None, 'md5': 'e3ac7609a6a8f005ea419529ca6839e1'}, {'id': '64da3de0788f0000010e5d51', 'gcst': 'GCST90277451', 'pmid': None, 'file_path': 'ac_impall_bilirubin.tsv', 'assembly': 'GRCh38', 'callback_id': 'UPciAwBx', 'readme': None, 'entryUUID': '70ef7d1b-4ef7-4846-bfdc-c3153f9c2522', 'author_name': None, 'rawSS': None, 'md5': 'a81f2b2e26f9780730d1b002e5cda16e'}, {'id': '64da3de0788f0000010e5d52', 'gcst': 'GCST90277452', 'pmid': None, 'file_path': 'ac_impall_CannabisEverTaken.tsv', 'assembly': 'GRCh38', 'callback_id': 'UPciAwBx', 'readme': None, 'entryUUID': '70ef7d1b-4ef7-4846-bfdc-c3153f9c2522', 'author_name': None, 'rawSS': None, 'md5': 'ea552cb15aa58c476ccb03f0b1c1287c '}]}] kwargs: {}.

            Exception was raised:

1 validation error for MetaModel minor_allele_freq_lower_limit value is not a valid float (type=type_error.float)

ljwh2 avatar Aug 21 '23 16:08 ljwh2

This seems to be stopping the files getting released, so needs prioritisation. See also goci#1076

ljwh2 avatar Sep 07 '23 15:09 ljwh2