efo icon indicating copy to clipboard operation
efo copied to clipboard

Removing self-xrefs from release

Open zoependlington opened this issue 2 years ago • 2 comments

fixes #752, #684

zoependlington avatar Jul 08 '22 10:07 zoependlington

Awesome! Thanks @zoependlington and @matentzn for the work on this! So as per remove-internal-xrefs.sparql, this removes any GO, DOID, Orphanet, HP, MONDO, or EFO xrefs where the xreffed term is a class in EFO?

And this removal happens during construction of the release? Such that these xrefs might still be in the source, just that they'll get filtered in the release? Presumably some of these xrefs also exist on EFO supplied terms (rather than just the dynamically imported terms). Would it make sense to also delete these xrefs from the source to avoid future confusion? Not necessarily in this PR.

dhimmel avatar Jul 11 '22 14:07 dhimmel

My ontology self says yes yes delete in source, but practically I would not recommend it due to the drastic loss of non-recoverable Information (think of future cases where terms are removed from efo or substituted for others, such as orphanet). I would personally recommend to keep them in the edit file (you need to delete them in any case from imported mappings, so the dynamic step in this pr cannot be avoided anyways).

matentzn avatar Jul 11 '22 15:07 matentzn