scream icon indicating copy to clipboard operation
scream copied to clipboard

Make RRTMG++ use Scorpio for reading

Open PeterCaldwell opened this issue 5 years ago • 5 comments

YAKL uses C++-Netcdf to read in netcdf files, while the rest of SCREAM uses a Scorpio interface to C-Netcdf. It would be nice to have a single interface for all processes within everything in SCREAM. This is perhaps impossible, however, since the C++-Netcdf calls are part of an external submodule dependency. We'd like to apply pressure to YAKL devs to internally include the C++ to netcdf C interface it needs. Iulian says that CPL already developed a nice solution to this.

PeterCaldwell avatar Dec 17 '20 17:12 PeterCaldwell

This is a follow-on to #810

PeterCaldwell avatar Dec 17 '20 17:12 PeterCaldwell

@brhillman is this still an issue?

AaronDonahue avatar Aug 05 '24 21:08 AaronDonahue

As of now, rrtmgp is still manually linking to netcdf, and manually using yakl's SimpleNetCDF data structure to handle reading in data in unit tests. So I think this issue still stands.

bartgol avatar Aug 06 '24 18:08 bartgol

@jgfouca , with the switch to Kokkos will we move away from YAKLs SimpleNetCDF data structure? If so, will be able to call this issue done?

AaronDonahue avatar Dec 06 '24 17:12 AaronDonahue

@AaronDonahue , we are currently using a Kokkos-ified version of SimpleNetCDF. We can move to something better at any time once Kokkos is default, but we have not done so yet.

jgfouca avatar Dec 06 '24 18:12 jgfouca