scream icon indicating copy to clipboard operation
scream copied to clipboard

TMS causes SGH30 to be written to restart uneccesarily

Open AaronDonahue opened this issue 1 year ago • 2 comments

@elynnwu discovered this when running a restart w/ latest master but with an older restart file. The restart initialization went looking for SGH in the restart file.

A little digging found that in TMS, SGH30 is a "required" field. For initialization this isn't an issue because the driver initializes SGH30 from the topography file. But at restart the logic instead goes looking for this variable in the restart file. Currently, it is also written to the restart file, so the bug won't impact any runs. But we should probably fix this because a typical user won't expect that SGH30 is being grabbed from a restart instead of the topo file, and we want to avoid writing fields to restart that don't need to be there.

AaronDonahue avatar Oct 13 '23 18:10 AaronDonahue

@tcclevenger I thought we put topography in the grid as a grid data field. Is there any reason not to do that?

bartgol avatar Oct 13 '23 18:10 bartgol

@bartgol We decided not to have phis as a grid data field, but I can't remember why, it was a while back. Maybe because dynamics need phis as an updated field (needed for PG2 case)? So it doesn't act typical geometry data fields

sgh30 is different, so we could make it a geo field. I just followed phis since they are loaded from the same file. No reason why they can't differ though. And we can still make phis a geo field if we want.

tcclevenger avatar Oct 13 '23 18:10 tcclevenger