E3SM icon indicating copy to clipboard operation
E3SM copied to clipboard

Activate MALI thermal solver and update configuration to be relevant to both AIS and GIS grids

Open matthewhoffman opened this issue 1 year ago • 2 comments

This PR updates a number of details about the MALI configuration to support both Antarctica and Greenland Ice Sheet configurations:

  • Enables the MALI thermal solver, which is needed to allow evolving calving fronts, in preparation for enabling calving
  • Adds new logic to make the albany_input.yaml file specific to a mesh. This is needed because AIS and GIS meshes use different solver boundary conditions that are specified in that file.
  • Enables config_remove_icebergs and config_remove_small_islands, two options that improve convergence of the velocity solver and are typically used in standalone MALI simulations
  • Adds additional fields to the MALI history files related to the now activated thermal solver, as well as ice-shelf basal melting. Also updates the MALI globalStats files to write out all global stats instead of the subset that was hardcoded before.
  • Updates the ERS_Ld5.TL319_oQU240wLI_ais20.MPAS_LISIO_JRA1p5.mpaso-ocn_glcshelf test to the MALI ais8to30 grid that was recently added. When the mesh was added, the test was failing due to issues with the thermal solver, but those have been resolved between https://github.com/E3SM-Project/E3SM/pull/6547 and this PR, so we can now update that test to the newer mesh.

matthewhoffman avatar Aug 21 '24 19:08 matthewhoffman

@stephenprice , here is the branch we were talking about that enables the thermal solver that you can test out with your various Greenland configurations.

@trhille , @stephenprice , @mperego , look over the changes to the namelist defaults and the new fields added to the history files and let me know if there is anything else you think we should include.

@mperego and @jonbob , let me know if you are happy with the way I've implemented supporting mesh-specific albany_input.yaml files.

@jonbob , I've only tested the test that is updated as part of this PR, so I will need help finding and running all the tests that use MALI.

matthewhoffman avatar Aug 21 '24 20:08 matthewhoffman

PR Preview Action v1.4.7 :---: :rocket: Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6559/ on branch gh-pages at 2024-08-27 22:48 UTC

github-actions[bot] avatar Aug 21 '24 20:08 github-actions[bot]

Passes:

  • ERP_Ld3.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850.chrysalis_intel.allactive-pioroot1
  • e3sm_landice_developer on chrysalis_gnu with expected DIFFs

Also successfully ran new test:

  • ERS_Ld5.TL319_oQU240wLI_ais8to30.MPAS_LISIO_JRA1p5.chrysalis_intel.mpaso-ocn_glcshelf

merged to next

jonbob avatar Sep 05 '24 20:09 jonbob

merged to master and expected DIFFs and NML DIFFs blessed except for mappy and pm-cpu_developer, which have not yet reported. But the new test is failing -- we probably will need to work on a new PR to change the test layouts as quickly as possible

jonbob avatar Sep 06 '24 18:09 jonbob

The new test isn't failing -- a recent CIME update changed the behavior for BFAILs. A fix is being merged and I'll add bless requests for the new test as soon as it changes the dashboard

jonbob avatar Sep 09 '24 20:09 jonbob