E3SM icon indicating copy to clipboard operation
E3SM copied to clipboard

Published 20 hours ago • verified publisher icon E3SM-Project

[WIP] FATES Land use V2 API update

Open glemieux opened this issue 10 months ago • 5 comments

This pull request adds the capability to read a landuse x pft mapping file to then be passed to fates. It also refactors the use_fates_logging namelist option from a switch to a mode select. This update allows the user to select a harvest mode that provides the mass or area-based land use harvest rates from the LUH2 landuse timeseries dataset.

The fates pull request associated with this update is https://github.com/NGEET/fates/pull/1116

glemieux avatar Apr 17 '24 20:04 glemieux

To do:

  • [x] update default parameter file

glemieux avatar Apr 23 '24 23:04 glemieux

Cleaned up the code per @samsrabin review via https://github.com/E3SM-Project/E3SM/pull/6353/commits/8cc7ddc6290f8b0f10c291941530705b26daefc6. Still need to check a couple of items.

glemieux avatar Apr 23 '24 23:04 glemieux

Needs a review approval

rljacob avatar May 30 '24 17:05 rljacob

Waiting on some FATES-side changes and PR #6419

rljacob avatar Jun 13 '24 17:06 rljacob

update: still waiting on some FATES-side changes

rljacob avatar Jun 27 '24 17:06 rljacob

@ckoven @samsrabin Now that this PR is finalized, it needs final review/approval

peterdschwartz avatar Jul 11 '24 22:07 peterdschwartz

Status update: Running e3sm_land_developer tests against the current master commit on perlmutter.

glemieux avatar Jul 17 '24 19:07 glemieux

@peterdschwartz regression testing using e3sm_land_developer on perlmutter against the master baseline is B4B for all expected tests. The DIFFs are all associated with fates tests and are expected.

Results: /pscratch/sd/g/glemieux/e3sm-tests/pr6353-eld-nanfix.fates.pm-cpu..E5b67e86c2a-F1982b003

glemieux avatar Jul 19 '24 16:07 glemieux

merged to next. from the e3sm_developer test suite, expecting diffs in:

  ERS_D_Ld15.f45_g37.IELMFATES.pm-cpu_intel.elm-fates_cold_treedamage (Overall: DIFF) details:
  ERS_Ld20.f45_f45.IELMFATES.pm-cpu_intel.elm-fates (Overall: DIFF) details:
  ERS_Ld30.f45_f45.IELMFATES.pm-cpu_intel.elm-fates_satphen (Overall: DIFF) details:
  SMS_D_Ld20.f45_f45.IELMFATES.pm-cpu_intel.elm-fates_rd (Overall: DIFF) details:
  SMS_Ld20.f45_f45.IELMFATES.pm-cpu_intel.elm-fates_eca (Overall: DIFF) details:
  SMS_Ld5_PS.f19_g16.IELMFATES.pm-cpu_intel.elm-fates_cold (Overall: DIFF) details:

peterdschwartz avatar Jul 22 '24 19:07 peterdschwartz

Merged to master. Some machines had issues so there will be a few DIFFs to bless tomorrow

peterdschwartz avatar Jul 23 '24 19:07 peterdschwartz