E3SM icon indicating copy to clipboard operation
E3SM copied to clipboard

Enable COSP for MMF

Open brhillman opened this issue 3 years ago • 2 comments

Enable COSP for MMF configurations. This involved a massive refactor of the COSP interface in cospsimulator_intr.F90. I think a lot of this refactor would be great to use for non-MMF configurations as well, but since the changes were so large and a lot of MMF-specific details are included, it was decided to move the refactored copy of the interface to the MMF (crm) directory to continue to keep the MMF-specific code isolated from the rest of the model. Note that the refactored interface in components/eam/src/physics/crm/cospsimulator_intr.F90 is still compatible with non-MMF configurations if we wanted to move it to components/eam/src/physics/cam/ (and in fact non-MMF COSP outputs are BFB even with the changes), but would need to either build crmdims.F90 or define dummy CRM dimensions some other way. Climate is BFB with this PR, but will require baseline blesses since the FRCE-MMF1 test is changed to use the COSP testmod.

[BFB]

brhillman avatar Aug 02 '22 17:08 brhillman

@brhillman looks like we still need to add a test with the COSP test mod to one of the suites.

whannah1 avatar Aug 02 '22 22:08 whannah1

@brhillman looks like we still need to add a test with the COSP test mod to one of the suites.

Fixed, I set the FRCE-MMF1 test to use the new eam-cosp_nhtfrq9 test mod (output every 9 steps, since this is a 9-step ERS test).

brhillman avatar Aug 03 '22 16:08 brhillman

Merged to next.

brhillman avatar Aug 30 '22 21:08 brhillman

Re-merged to next following bug fix.

brhillman avatar Sep 01 '22 19:09 brhillman