e2openplugin-OpenWebif icon indicating copy to clipboard operation
e2openplugin-OpenWebif copied to clipboard

name contains an apostrophe

Open demosat opened this issue 2 years ago • 20 comments

Hi, It is not possible to zap on a channel when click on the name of the chain when it contains an apostrophe.

Example with French channels : L'Equipe (5w, 13e, 19.2e) TOUTE L'HISTOIRE (5w and 13e)

demosat avatar May 28 '22 19:05 demosat

Ooh, thought we'd fixed this ages ago. Are you uusing the modern or classic interface?

wedebe avatar May 29 '22 22:05 wedebe

this is screen shoot. Screenshot 2022-05-30 at 18-49-32 Edision OS Mio 4K - OpenWebif

demosat avatar May 30 '22 16:05 demosat

All interfaces are affected by the problem.

demosat avatar Jun 03 '22 20:06 demosat

I've found an issue with the event detail modal in the modern interface.

@demosat, have you seen this happen elsewhere in the modern interface?

wedebe avatar Jun 18 '22 09:06 wedebe

@demosat, have you seen this happen elsewhere in the modern interface?

Yes, All interfaces are affected by the problem.

demosat avatar Jun 18 '22 10:06 demosat

@demosat, have you seen this happen elsewhere in the modern interface?

Yes, All interfaces are affected by the problem.

Could you be more specific about exactly where (within each interface) the issue happens when you zap, please? The now/next list was fixed some time ago, I've just now submitted a fix for the programme details popup.

wedebe avatar Jun 18 '22 10:06 wedebe

All skins have problem. It is not possible to zap on a channel when click on the name of the chain when it contains an apostrophe. If you have possibility, test on channel orbital 5w or 13e or 19.2e with "L'equipe" or "Toute l'histoire" But i waiting your fix on update opkg Thanks for your job

demosat avatar Jun 18 '22 11:06 demosat

I've tried on both modern and classic interfaces and I can zap to "L'equipe" just fine 🤔. (OWIF 1.5.1 / Build: 1.5.0-git4413+16a8d01-r0) Could it be an issue with the bouquet? For reference, here is the link as it is shown on my box: <a href="javascript:zapChannel('1:0:1:141:3E1C:13F:820000:0:0:0:', 'L\'EQUIPE');" class="link--skinned" title="Zap için L'EQUIPE">L'EQUIPE</a>

t5k6 avatar Jun 19 '22 10:06 t5k6

I use latest openpli 8.2 root@osmio4kplus:~# opkg list | grep openwebif enigma2-plugin-extensions-openwebif - 1+git4396+f551074-r0.1 - enigma2-plugin-extensions-openwebif version 1+gitAUTOINC+f5510743e1-r0

demosat avatar Jun 19 '22 14:06 demosat

I remove openwebif -> reboot > install enigma2-plugin-extensions-openwebif_latest_all.ipk 18:30 paris local time (https://github.com/E2OpenPlugins/e2openplugin-OpenWebif/raw/gh-pages/enigma2-plugin-extensions-openwebif_latest_all.ipk) I test on Firefox or Chrome, but problem isn't solved.

demosat avatar Jun 19 '22 16:06 demosat

@demosat, please take a screenshot and mark everywhere you experience this problem.

wedebe avatar Jun 20 '22 08:06 wedebe

Hi, i make video for this problem. look my video please, i deposit on megaupload. https://mega.nz/file/WzBVSJiS#txA7IRNHffBDSWvBw-Eg8fWpTIXT1WaxunWoG8Tqpi0

demosat avatar Jun 20 '22 09:06 demosat

Have you understood the problem with my video following the action of the cursor on the computer ?

demosat avatar Jun 21 '22 11:06 demosat

the provided link doesn't work- see html for Build: 1.5.1-git20220619-r1 <a href="javascript:zapChannel('1:0:19:2076:432:1:C00000:0:0:0:', 'L'EQUIPE');" class="link--skinned" title="Umschalten auf L'EQUIPE">L'EQUIPE</a>

magicsepp avatar Jun 21 '22 15:06 magicsepp

Compare good link <a href="#" onclick="zapChannel("1:0:19:2332:442:1:C00000:0:0:0:", "INFOSPORT+"); return false" title="Zapper vers INFOSPORT+">INFOSPORT+</a>

bad link <a href="#" onclick="zapChannel("1:0:19:2076:432:1:C00000:0:0:0:", "L" equipe");="" return="" false'="" title="Zapper vers L'EQUIPE">L'EQUIPE</a>

Sans-titre-1

demosat avatar Jun 21 '22 16:06 demosat

Why not ? replace("'","&#39;")

jbleyel avatar Jun 21 '22 16:06 jbleyel

No issue here Bildschirmfoto 2022-06-21 um 18 35 59 .

jbleyel avatar Jun 21 '22 16:06 jbleyel

@Jblleyel, i dont touch or modification code, i just post screenshoot on console I compar good link for normal name vs bad link name wtih apostrophe

demosat avatar Jun 21 '22 17:06 demosat

@jbleyel , it's the ' in the sref and/or name that's closing the zapChannel js string prematurely.

(Some browsers will render the wysiwyg code as they interpreted it)

wedebe avatar Jun 21 '22 17:06 wedebe

I really want to rewrite the zap function completely but don't have the time at the moment.

wedebe avatar Jun 21 '22 17:06 wedebe