xcode-github icon indicating copy to clipboard operation
xcode-github copied to clipboard

Monitor for Pull Requests not available

Open andreas-braun-parship opened this issue 6 years ago • 13 comments

I'm experimenting with the app right now but configuring it as described in the README I'm unable to start the pull request monitoring.

The menu entry for it is just inactive and I can't see what's wrong with it in the logs.

andreas-braun-parship avatar Jul 25 '19 11:07 andreas-braun-parship

Did you add the Xcode server through preference panel? Does the server appear in the Status window? Do you see the bots on the server in the Status window?

Open the Log window and turn on 'Show debug messages' check box located on the bottom of the window. Hopefully some informative messages will be visible now.

E-B-Smith avatar Jul 26 '19 00:07 E-B-Smith

Did all of that, yes

The Server appears and all the bots are shown, I just can't select Show Pull Requests and Monitor for Pull Requests. The Monitor Repo for Pull Requests under the View Menu is also deactivated.

I checked the Log and it only connects to the Xcode Server, there is no connection to GitHub and the Token I generated is still unused according to Github.

andreas-braun-parship avatar Jul 26 '19 06:07 andreas-braun-parship

Which version of Xcode are you running?

Also, can you post a screen shot of you Status window and your log window? You can email them to me if you don't want them public.

eb-smith-affirm avatar Jul 26 '19 20:07 eb-smith-affirm

I blocked out the repository but it is correct

Xcode 10.2.1 at the moment, but I want to update to 10.3.0

Is that feature depending on Xcode? Looks to me like an issue with GitHub since the token is not used at all.

Bildschirmfoto 2019-07-29 um 08 42 38 Bildschirmfoto 2019-07-29 um 08 42 19 Bildschirmfoto 2019-07-29 um 08 42 10 Bildschirmfoto 2019-07-29 um 08 41 59

andreas-braun-parship avatar Jul 29 '19 06:07 andreas-braun-parship

I apologize for not being responsive on this - I got busy with work and holiday.

Is this still an issue for you? If so I can work with you on it. Maybe we can set up a time to work on this that works for both our timezones.

E-B-Smith avatar Sep 12 '19 19:09 E-B-Smith

@E-B-Smith I'm seeing something similar, fwiw. Is it perhaps because I have multiple bots on master for the same repo? (They run different schemes).

I see from the screenshots that @andreas-braun-parship seems to have the same thing – at least I think that's what the repeated lines for the same branch mean. (Ideally there would be another column showing the Scheme selected under the Configuration setting of the "Edit Bot..." window, but I'm guessing that's not possible. Or, it could show the "nice" name that is in the Edit Bot... Info tab. ).

Here's my screenshot - I'm afraid it probably doesn't make much sense without the repos. There are three total. They all used to have 3x bots per repo: master, develop-1 and develop-2. The two repos together with the red boxes next to them has two bots: both on master, but both with different schemes selected. (One scheme has "Cloud tests" in it, which tend to fail more often so I keep them separate). Ignore the rest!

🤞 I can get this going. We keep missing failed tests and merging PRs on GitHub because we can. Before we switched to Xcode Server (from Buddy Build), this was never a problem because it wasn't possible :) Many thanks for taking the time to make this available!

Screen Shot 2019-09-22 at 8 16 21 pm

mikemee avatar Sep 22 '19 12:09 mikemee

Same problem here using macOS 10.14.6 with Xcode 11. Did someone found any solution ?

AlexNsbmr avatar Oct 04 '19 13:10 AlexNsbmr

As @mikemee correctly suspected I also have multiple schemes for the same branch running different targets.

andreas-braun-parship avatar Oct 07 '19 08:10 andreas-braun-parship

I am also seeing this, although I have some thoughts:

  • Two bots, each target different branches, but use the same scheme.
  • Only the first bot gives me the option to monitor PRs
  • When i enable it, it tries to build ALL PRs for ALL branches, not just the branch the bot targets

I think that the service is allowing monitoring of PRs generally for whichever bot was configured first, and then using that bot to try to monitor all PRs regardless of branch.

So, likely just a small bug. Lmk if screenshots would be helpful @E-B-Smith

DanBurkhardt avatar Oct 08 '19 15:10 DanBurkhardt

Hmm, with all this information and recent interest, it’s probably time for me to look at the source code and hopefully make a PR...

mikemee avatar Oct 09 '19 00:10 mikemee

Confirmation: This seems to be caused by having multiple schemes.

I recently removed the "cloud test" specific scheme that I had in one project (tl;dr: automated testing of CloudKit in the simulator is too unreliable) and then found I had the option of "Monitor for Pull Requests". The other project I have that still has multiple schemes still does not have that option.

mikemee avatar Oct 10 '19 03:10 mikemee

Not exactly sure because I can only read, not develop in, Obj-C, but I think that the investigation starts on this line: https://github.com/E-B-Smith/xcode-github/blob/410bc632cc197aed469562203de34d9715b7964b/xcode-github-app/XGAStatusViewController.m#L131

DanBurkhardt avatar Oct 10 '19 10:10 DanBurkhardt

The fix for me was to add the repo using ssh (can't use https to clone)

fawkeswei avatar Sep 16 '20 11:09 fawkeswei