Dyno-Custom-Commands icon indicating copy to clipboard operation
Dyno-Custom-Commands copied to clipboard

Update Commands

Open ghost opened this issue 4 years ago • 7 comments

Update

  • Update Dyno RPG Commands
  • Add Profile commands
  • Add Reports Commands

Note

Ignore the create modules commit. I closed that one in favor of using more fitting subfolders.

ghost avatar Mar 19 '21 15:03 ghost

I can check for typos. I didn't see any before but will gladly fix any that are there. As for the strand CC commands I actually removed most of those and am sticking to mostly my own. The profiles is the only one kept and I plan to make my own edits to those tbh.

PhantomNimbi avatar Mar 19 '21 15:03 PhantomNimbi

It is of my personal opinion that taking commands from StrandCC, which it turns out is still an active organization, and bringing them into our repo is not an ethical course of action. On that note, within the RPG module there are also quite a few typos that could use fixing. Please make sure to review the module w/ a spell checker.

Ok I finished going over it all. The Modules folder is the one I chose to remove. Thus the comment about ignoring the create modules commit. As for the StrandCC Commands I actually didn't keep any of those.

I learned from their methods for the setup command and basically made my own setup commands for use with the only three modules I have.

My RPG commands have their own and my reports command has it's own but other than that the Profiles module is one I'm editing over time. I plan to add a set-games command as soon as i get it to accept a different format lol

PhantomNimbi avatar Mar 19 '21 16:03 PhantomNimbi

Ok finally after going over it more I noticed a lot of the setup commands didn't work. So I removed the setups. this also defeated the entire purpose of the reports module so i deleted it entirely. The setup commands relied on commands that must have been removed. So They simply won't be getting implemented sadly.

PhantomNimbi avatar Mar 19 '21 17:03 PhantomNimbi

Ready for Review

  • All Updates pushed for now

PhantomNimbi avatar Mar 19 '21 18:03 PhantomNimbi

The typos should all be fixed now, awaiting review.

PhantomNimbi avatar Mar 20 '21 18:03 PhantomNimbi

Just letting you know that I'm getting started on reviewing this.

Swordington avatar Mar 21 '21 14:03 Swordington

Update 03/22/2021

  • Applied requested fixes.
  • Ready for review.

PhantomNimbi avatar Mar 23 '21 03:03 PhantomNimbi