VersionChecker icon indicating copy to clipboard operation
VersionChecker copied to clipboard

Version Checker 1.1.6a Showing Incorrect amount of updates

Open SJ1133 opened this issue 11 years ago • 11 comments

screenshot_3

The game shows up with 36 updates even when i only have 1 or 2 mods out of date

SJ1133 avatar Sep 15 '14 09:09 SJ1133

Is it also showing these updates in the update list or is it just the number on button that's incorrect?

EDIT: If these updates also show in the update list, could you make a screenshot of the list?

Dynious avatar Sep 15 '14 11:09 Dynious

These updates also show in the update list. See Screenshots check1 check2 check3 check4 check5 check6

SJ1133 avatar Sep 15 '14 12:09 SJ1133

Yeap, pretty much in the same boat... Some mods simply have incorrect version data (authors set improper version flag), for such it's understandable that Version Checker is offering newer file (the case of TYNKYN for a fact).

Also look at the case of Random Things, offering older version compared to the newer one already installed... Might want to eliminate that somehow form VersionChecker?

Painstouch avatar Sep 17 '14 07:09 Painstouch

Thanks for the screenshots!

It seems like there are a good amount of correct ones in there, but a lot of them are incorrect. In most of these cases it is impossible for me to fix the false-positive. If you really don't want to get false-positives you can disable NotEnoughMods checking in the config.

Also, it should check if the version is newer than the installed one (this works fine for BluePower for example). I will do a check of my code again to see if I can optimize it.

Dynious avatar Sep 18 '14 16:09 Dynious

There is an option to fix most problems: add a vote-type system so incorrect updates are blocked when a certain amount of people vote them out. It should be as simple as pressing a 'This update is incorrect' button. This should then send this info (the vote and the incorrect 'old' and 'new' version) to a server. Every time a check is done it will download the list of blocked mods not check them.

This is a lot of work (maybe too much work?), requires some server coding (which I have never done) and requires a server.

Dynious avatar Sep 18 '14 16:09 Dynious

A vote system seems like overkill to me. I think some aggressive false positive filtering might be better (only show updates that you can be certain are real).

From the screenshots, it seems like a simple way to do that would be to simply compare the number of tokens of each string (by splitting them by non-alphanumeric characters). That way, 1.0.0 against 1.0.0-test would be ignored (3 tokens != 4 tokens). It may filter out some real updates, but it'll definitely remove a lot of false positives.

Another check that'd probably have a similar result would be to do if (nemVersion.startsWith(currentlyInstalledVersion)) and assume anything that evaluates as true to be a false positive.

squeek502 avatar Sep 18 '14 21:09 squeek502

This was auto-closed, but reopend by me to discuss the improvements that will be released in 1.1.6b.

Dynious avatar Sep 24 '14 19:09 Dynious

Looking forward to it!

Painstouch avatar Sep 24 '14 19:09 Painstouch

I still got the wrong update notification, i updated the mod already but some mod still show them are not latest version....my version checker's version is 1.1.8 untitled

nogamenofun98 avatar Mar 06 '15 11:03 nogamenofun98

I would assume most of those mods have incorrect versions set in their mcmod.info. Not much Version Checker can do about that.

squeek502 avatar Mar 06 '15 20:03 squeek502

Can we edit the info file? Although every update the info will change back..

nogamenofun98 avatar Mar 07 '15 14:03 nogamenofun98