BizOpsConfigurator icon indicating copy to clipboard operation
BizOpsConfigurator copied to clipboard

"sha" is not a unique reference to the file

Open gabrielprioli opened this issue 3 years ago • 0 comments

Could we please change the "keyPath" from "sha" to "download_url"?

https://github.com/Dynatrace/BizOpsConfigurator/blob/a1fe50d7d511d26304d2777d23bb1df6498d9068/js/indexeddb.js#L32 https://github.com/Dynatrace/BizOpsConfigurator/blob/a1fe50d7d511d26304d2777d23bb1df6498d9068/js/indexeddb.js#L34 https://github.com/Dynatrace/BizOpsConfigurator/blob/a1fe50d7d511d26304d2777d23bb1df6498d9068/js/indexeddb.js#L35

As we can see in the image below, the "sha" value is the same, even though the files are different: "aws-es-readme.md" and "aws-pt-readme.md".

image

Changing it to "download_url" would make it unique because it includes the file name in the url.

gabrielprioli avatar Jul 05 '21 21:07 gabrielprioli