dynamorio icon indicating copy to clipboard operation
dynamorio copied to clipboard

Android: Changes that improve AArch64 Android cannot be tested on 32-bit ARM Android

Open felixc-arm opened this issue 11 months ago • 2 comments

Currently we cannot test the runtime behaviour of 32-bit ARM Android, and so when making changes to DR that are known to work on and improve 64-bit AArch64 Android, we do not know if the change would benefit 32-bit Android or not.

To reduce the risk of breaking 32-bit Android, most of these changes will be applicable to 64-bit Android only, even if they might benefit or fix issues on 32-bit Android as well.

If these types of changes are linked with this issue then hopefully the changes can be easily found and tested on 32-bit Android if the hardware/effort becomes available.

felixc-arm avatar Jan 24 '25 10:01 felixc-arm

Duplicate of #4639?

derekbruening avatar Apr 14 '25 16:04 derekbruening

I think this issue was more to do with places in the code where we separated 32-bit Arm Android code and new 64-bit Aarch64 Android code, i.e. the 32-bit code won't work for the 64-bit build, but we won't touch/change the 32-bit code as we won't know the effect of our changes as we can't test them.

Grepping shows this issue is in 3 places in the code, and the idea was that if 32-bit Android testing was every re-implemented (or 32-bit Android support was removed I guess), then you could grep for this issue and then change the 32-bit code accordingly.

felixc-arm avatar Apr 15 '25 08:04 felixc-arm