dynamorio icon indicating copy to clipboard operation
dynamorio copied to clipboard

Improve drcachesim -indir and -outdir docs, directory contents are internal

Open xdje42 opened this issue 1 year ago • 3 comments

If the user happens to, for example, create a file in this directory then drcachesim will complain that it doesn't understand the file. Warn the user that the contents of these directories are internal to the tool.

xdje42 avatar Apr 19 '24 23:04 xdje42

Ping

xdje42 avatar May 08 '24 15:05 xdje42

Ping

Normally you'd click on the re-request review to indicate it's ready for a look: otherwise the reviewer will assume it's still being worked on.

derekbruening avatar May 08 '24 15:05 derekbruening

Ping

Normally you'd click on the re-request review to indicate it's ready for a look: otherwise the reviewer will assume it's still being worked on.

Please see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/requesting-a-pull-request-review

derekbruening avatar May 08 '24 16:05 derekbruening