dynamorio icon indicating copy to clipboard operation
dynamorio copied to clipboard
verified publisher icon DynamoRIO

Minor changes to permit building with older toolchains.

Open egrimley-arm opened this issue 2 years ago • 4 comments

Make some code conditional on EM_RISCV or PR_SVE_GET_VL being defined. This was needed on RHE7, which will be around for a few more years.

We also check for another older macro not being defined in case all the macros get replaced by an enum.

egrimley-arm avatar Nov 29 '23 08:11 egrimley-arm

The x86 failures look like https://github.com/DynamoRIO/dynamorio/issues/6417

AssadHashmi avatar Dec 01 '23 20:12 AssadHashmi

On RHEL 7, /usr/include/elf.h does not define EM_RISCV, but now we have third_party/elfutils/libelf/elf.h that does define it. Could we use the latter header instead of the former?

prasun3 avatar Jan 18 '24 04:01 prasun3

On RHEL 7, /usr/include/elf.h does not define EM_RISCV, but now we have third_party/elfutils/libelf/elf.h that does define it. Could we use the latter header instead of the former?

Submodules used to be optional but we did make elfutils required on Linux so yes that seems reasonable.

derekbruening avatar Jan 18 '24 14:01 derekbruening

On RHEL 7, /usr/include/elf.h does not define EM_RISCV, but now we have third_party/elfutils/libelf/elf.h that does define it. Could we use the latter header instead of the former?

@egrimley-arm do you want to try this approach if you are still planning to work on this issue

prasun3 avatar Jan 23 '24 08:01 prasun3