dynamorio icon indicating copy to clipboard operation
dynamorio copied to clipboard

Published 20 hours ago • verified publisher icon DynamoRIO

i#3544 RISC-V, part 5: Add atomic functions

Open semihalf-kardach-stanislaw opened this issue 3 years ago • 5 comments

Add RISC-V implementation of most atomic functions. Several are left unimplemented (the exchange variants), only containing a non-atomic logic as a reminder of what the given function should do.

Issue: #3544

Signed-off-by: Stanislaw Kardach [email protected]

semihalf-kardach-stanislaw avatar Jul 22 '22 08:07 semihalf-kardach-stanislaw

Is this ready for review? (checking since I didn't see a review request)

abhinav92003 avatar Jul 22 '22 14:07 abhinav92003

Thanks for your review! I'll be OoO for the next 8 days so I'll get to fixing this PR once I get back.

semihalf-kardach-stanislaw avatar Jul 22 '22 16:07 semihalf-kardach-stanislaw

@abhinav92003 I've updated this PR and now it's ready for the review.

semihalf-kardach-stanislaw avatar Aug 04 '22 07:08 semihalf-kardach-stanislaw

I've approved but please wait for Derek to have a look too and resolve the pending comments.

abhinav92003 avatar Aug 05 '22 14:08 abhinav92003

@derekbruening I'm not sure whether I can mark the last 2 conversations as resolved, hence the re-review request from me.

semihalf-kardach-stanislaw avatar Aug 10 '22 13:08 semihalf-kardach-stanislaw