dynamorio icon indicating copy to clipboard operation
dynamorio copied to clipboard

Client argv not NULL terminated

Open algrant-arm opened this issue 2 years ago • 1 comments

Docs say "The client's options are passed directly to its dr_client_main() initialization routine, in the same manner as arguments are passed to a regular application's main() routine". The C standard says that argv must be NULL terminated, but DR fails to set this up, so option parsers that rely on this will crash.

Looks like the fix is in parse_option_array. The free in free_option_array will also need changing.

algrant-arm avatar Mar 14 '22 23:03 algrant-arm

Would you like to send out a PR with that fix?

bete0 avatar May 18 '22 16:05 bete0