RefineryToolkits icon indicating copy to clipboard operation
RefineryToolkits copied to clipboard

Visibility.OfLinesFromOrigin not considering correct obstructions

Open paoloemilioserra opened this issue 5 years ago • 8 comments

Passing the center of the desk as origins, the lines for the windows, the polygon for the boundary, the desks as obstructions.

paoloemilioserra avatar Oct 07 '19 14:10 paoloemilioserra

Ignoring the obstructions I get this (in red the only one I'm expecting to see with obstructions).

image

Instead I get nothing image

paoloemilioserra avatar Oct 07 '19 14:10 paoloemilioserra

Thanks @paoloemilioserra ! Would you be able to share the script/dataset or just this part of it?

radumg avatar Oct 07 '19 20:10 radumg

Hi @paoloemilioserra

Can't seem to reproduce this, could you share the dataset or can I close this?

SHKnudsen avatar Oct 11 '19 14:10 SHKnudsen

@SHKnudsen I can't share the file but the issue appears to be in a "polyline branching" error thrown in the node that returns null

paoloemilioserra avatar Oct 12 '19 00:10 paoloemilioserra

Thanks @paoloemilioserra , @SHKnudsen is trying to reproduce the error, any dataset or further screenshots of the graph just before that node would be very helpful.

The polyline branching error is a LiBG error.

radumg avatar Oct 21 '19 10:10 radumg

hey @paoloemilioserra , any chance we can get some data to help us replicate this ? Would like to fix these open bugs in Q4. Happy to do a Zoom call if it's easier ?

radumg avatar Nov 27 '19 07:11 radumg

I cannot reproduce this error. This graph demonstrates it working as expected. What may have happened to @paoloemilioserra and something I found was, that I was patching the view cones incorrectly at first. image

20210121-VisibilityCompare.zip

johnpierson avatar Jan 22 '21 16:01 johnpierson

Actually, I might've spoken too soon. The above example at 0.275 for the input does reproduce this. image

johnpierson avatar Jan 22 '21 18:01 johnpierson