DynamoRevit icon indicating copy to clipboard operation
DynamoRevit copied to clipboard

Point.PruneDuplicates Inconsistent Units

Open karambk opened this issue 3 years ago • 6 comments

Dynamo version

2.10

Revit version

Revit 2022

Operating system

Windows 10

What did you do?

Used Point.PruneDuplicates

What did you expect to see?

Points being pruned at a tolerance using the same display units of the current active project

What did you see instead?

Points being pruned at a tolerance using Feet units regardless of the current active project

Notes

All Dynamo for Revit versions used tolerance value as the same display units of the current active project, changing this behavior in Revit 2022 breaks so many older workflows

karambk avatar Aug 16 '21 21:08 karambk

@Amoursol Hey Sol, it's been a while :)

Beside that, Is this change intended ? will it stay like that ? I need to know in order to edit my scripts accordingly. Thanks :)

karambk avatar Aug 19 '21 14:08 karambk

@ZiyunShang this appears to be another regression in D4R - is it possible to investigate?

Amoursol avatar Aug 19 '21 15:08 Amoursol

Hi @Amoursol , this node is a Dynamo Geometry node, I can't find its code on my side. But I guess it may be impacted by Revit UnitType API changes.

ZiyunShang avatar Aug 20 '21 01:08 ZiyunShang

@ZiyunShang Ah, yes probably 😢 @aparajit-pratap do you think this is the case and can we take a look?

Amoursol avatar Aug 20 '21 02:08 Amoursol

@ZiyunShang @Amoursol @aparajit-pratap I made a bit of investigation, it seems that if the points are generated inside dynamo, they are pruned with tolerance using display units

But if the points are grabbed by the location of Revit element, they are pruned using internal units feets

It's complicated

Previously, no matter what's the way we generate the points, the pruning worked using display units.

Hope that helps.

karambk avatar Aug 21 '21 19:08 karambk

@QilongTang - Based on what Karam wrote above, do we think this lies on our side? Or on D4R?

Amoursol avatar Mar 11 '22 22:03 Amoursol