Dynamo icon indicating copy to clipboard operation
Dynamo copied to clipboard

DYN-8326 - copy to clipboard button for warning bubble

Open jasonstratton opened this issue 5 months ago • 4 comments

I will update the PR when I get images from UX

Purpose

(FILL ME IN) This section describes why this PR is here. Usually it would include a reference to the tracking task that it is part or all of the solution for.

Declarations

Check these if you believe they are true

  • [ ] Is documented according to the standards
  • [ ] The level of testing this PR includes is appropriate
  • [ ] User facing strings, if any, are extracted into *.resx files
  • [ ] Snapshot of UI changes, if any.
  • [ ] Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • [ ] This PR modifies some build requirements and the readme is updated
  • [ ] This PR contains no files larger than 50 MB
  • [ ] This PR introduces new feature code involve network connecting and is tested with no-network mode.

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Use N/A to indicate that the changes in this pull request do not apply to Release Notes. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

jasonstratton avatar Jun 17 '25 23:06 jasonstratton

Looks like I need to update the description with release notes, etc when I update the images (failed PR Description check)

jasonstratton avatar Jun 17 '25 23:06 jasonstratton

It did not appear that this would be conducive to unit tests, but I could probably use some guidance in that area, including where to add any tests.

I think it will be more appropriate to write an AGT test and will do so after the PR is merged.

jasonstratton avatar Jun 17 '25 23:06 jasonstratton

Looks like there is an issue with declaring this as part of the API? I will need some guidance there as well.

jasonstratton avatar Jun 17 '25 23:06 jasonstratton

Looks like there is an issue with declaring this as part of the API? I will need some guidance there as well.

You will have to declare the public APIs in the log, you can use the Visual Studio suggestion to do it for you, or add it manually: Screenshot 2025-06-17 at 11 07 27 PM

zeusongit avatar Jun 18 '25 03:06 zeusongit

Some minor comments, and I think you can now update the PR description

zeusongit avatar Jun 24 '25 02:06 zeusongit