Dynamo icon indicating copy to clipboard operation
Dynamo copied to clipboard

DYN-7206: Improve list of selected ids when long

Open twastvedt opened this issue 1 year ago • 1 comments

Purpose

When a user selects elements from Revit in a Dynamo Player script, the ids of the selected elements are listed in the Player UI. However, to avoid an overly long display, only up to 20 ids are shown. When a user selects more than 20 the list is confusing because no indication is given that the list is partial, except that its length does not match the total count shown.

image-2024-6-25_22-40-10

This PR adds an ellipses at the end of the list if it does not list all the selected elements. It also adds commas between element IDs.

Reported in testing here.

Declarations

Check these if you believe they are true

  • [ ] The codebase is in a better state after this PR
  • [ ] Is documented according to the standards
  • [ ] The level of testing this PR includes is appropriate
  • [ ] User facing strings, if any, are extracted into *.resx files
  • [ ] All tests pass using the self-service CI.
  • [ ] Snapshot of UI changes, if any.
  • [ ] Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • [ ] This PR modifies some build requirements and the readme is updated
  • [ ] This PR contains no files larger than 50 MB

Release Notes

Improved the display of long lists of selected element ids in Dynamo Player.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

twastvedt avatar Jul 01 '24 20:07 twastvedt

UI Smoke Tests

Test: success. 11 passed, 0 failed. TestComplete Test Result Workflow Run: UI Smoke Tests Check: UI Smoke Tests

github-actions[bot] avatar Jul 01 '24 20:07 github-actions[bot]

LGTM!

BogdanZavu avatar Jul 18 '24 15:07 BogdanZavu

This is ready to merge @QilongTang. I reran SelfServe, it succeeded. I saw a note of yours in Slack that that doesn't update the build status here for some reason? Can we disable protection in order to merge this? Thanks!

twastvedt avatar Aug 19 '24 14:08 twastvedt