Dynamo icon indicating copy to clipboard operation
Dynamo copied to clipboard

DYN-6427 & DYN-6828 Graph Properties UI Fixes

Open saintentropy opened this issue 9 months ago • 1 comments

Purpose

This PR fixes two data loss bugs with Graph Properties View Extension interaction.

  • First is the scenario when you have graph properties defined in a graph but open a custom node. When you return to the graph and save the graph properties are lost. This GraphMetaDataView extension is updated here to handle this case when the Workspace is cleared or changed.

  • Second is related to naming auto-naming the custom properties. You adding a deleting you can get into a scenario where the logic suggest the same property name. This PR adjust the logic to insure unique auto properties names

Declarations

Check these if you believe they are true

  • [x] The codebase is in a better state after this PR
  • [ ] Is documented according to the standards
  • [ ] The level of testing this PR includes is appropriate
  • [ ] User facing strings, if any, are extracted into *.resx files
  • [ ] All tests pass using the self-service CI.
  • [ ] Snapshot of UI changes, if any.
  • [ ] Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • [ ] This PR modifies some build requirements and the readme is updated
  • [ ] This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

@twastvedt @BogdanZavu

FYIs

@jnealb

saintentropy avatar May 07 '24 14:05 saintentropy

UI Smoke Tests

Test: success. 2 passed, 0 failed. TestComplete Test Result Workflow Run: UI Smoke Tests Check: UI Smoke Tests - net8.0

github-actions[bot] avatar May 07 '24 15:05 github-actions[bot]