Dynamo icon indicating copy to clipboard operation
Dynamo copied to clipboard
verified publisher icon DynamoDS

Update Excel.cs

Open denizmaral opened this issue 2 years ago • 6 comments

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Related to https://github.com/DynamoDS/DynamoWishlist/issues/200

Declarations

Check these if you believe they are true

  • [ ] The codebase is in a better state after this PR
  • [ ] Is documented according to the standards
  • [ ] The level of testing this PR includes is appropriate
  • [ ] User facing strings, if any, are extracted into *.resx files
  • [ ] All tests pass using the self-service CI.
  • [ ] Snapshot of UI changes, if any.
  • [ ] Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • [ ] This PR modifies some build requirements and the readme is updated
  • [ ] This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

denizmaral avatar Jun 09 '23 15:06 denizmaral

Changed to draft PR temporarily while we look into some CICD issues.

pinzart90 avatar Jun 12 '23 15:06 pinzart90

@denizmaral this is an opensource project. For the benefit of everyone it would be extremely useful if you write a description and purpose for this PR if nothing else.

aparajit-pratap avatar Jun 26 '23 20:06 aparajit-pratap

Please see the Feature request https://github.com/DynamoDS/DynamoWishlist/issues/200

denizmaral avatar Jun 26 '23 21:06 denizmaral

hi @aparajit-pratap Do you know the latest state on this PR? Is this something we could ship now?

QilongTang avatar Apr 09 '24 18:04 QilongTang

I think the changes in this PR need to be moved from DSOffice/Excel.cs to DSOfficeUtilities/Excel.cs We moved all Excel types/dependencies into DSOfficeUtilities because of issues with embedded types and the Dynamo engine FYI @aparajit-pratap @QilongTang @denizmaral

pinzart90 avatar May 13 '24 18:05 pinzart90