Dynamo
Dynamo copied to clipboard
GraphNodeManager Update
Purpose
This is a compound PR targetting multiple bug fixes and updates for the GraphNodeManagerViewExtension. The list below shows the list of running comments and issues that are being solved with the PR.
- [x] Nested Empty Lists
- [x] Filter Label Consistent Capitalisation
- [x] Tooltip bubble arrow of Export and Copy needs to be flipped
- [x] Update Export to Excel tooltip
- [x] Warning/error font color update (brighten, currently low contrast)
- [x] Dismissed warning not showing up in GNM in Automatic Mode
- [x] Hover state (color) of alternating rows
- [x] Consistent selected bar color (no state) - currently affected by alternating row color
- [x] 'Search' placeholder text update
- [x] 'Search' exits focus when clicking outside the search field
- [x] Alignment: first icon to align to column header (title)
- [x] Vertical lines look dashed
- [x] Export to CSV/JSON - populate a default name
- [x] (Performance) - GNM + Custom Nodes (Spring, Clockwork) laggy behaviour
- [x] Blue Dot denoting renamed nodes
- [x] Icons to Filters
- [x] ~~JSON exported file error on opening~~ could not recreate the issue
- [x] Drop-down file option JSON/CSV bug
- [x] Navigating away from a selected node not resetting selection (when clicking again, won't zoom on the node again)
- [x] Export only exports unfiltered nodes
- [x] Alternative export CSV/JSON tooltip when filter(s) are on
- [x] Show any null or emptylist
Declarations
Check these if you believe they are true
- [x] The codebase is in a better state after this PR
- [ ] Is documented according to the standards
- [ ] The level of testing this PR includes is appropriate
- [ ] User facing strings, if any, are extracted into
*.resxfiles - [x] All tests pass using the self-service CI.
- [x] Snapshot of UI changes, if any.
- [ ] Changes to the API follow Semantic Versioning and are documented in the API Changes document.
- [ ] This PR modifies some build requirements and the readme is updated
Release Notes
A series of bug fixes or updates to the View Extension.
- (nested empty lists) added a recursion to the IsNodeEmptyList method to factor in nested empty lists

- (dismissed alerts count) a few limitations: only the NodeModel is visible; the DismissedAlerts inside the NodeModel won't raise PropertyChanged. Therefore introduced a dedicated property for DismissedAlertsCount inside the NodeModel that raises PropertyChanged and can be detected from the View Extension

Reviewers
@reddyashish @mjkkirschner
FYIs
@Amoursol