Dynamo icon indicating copy to clipboard operation
Dynamo copied to clipboard

DYN-4224 / DYN-4225 Watch3d Updates (Persistent camera and node size between saves / Ignore Node preview state)

Open saintentropy opened this issue 3 years ago • 0 comments

Purpose

This PR covers https://jira.autodesk.com/browse/DYN-4224 and https://jira.autodesk.com/browse/DYN-4225

This PR updates the behavior of the Watch3d node in three ways.

  1. Fix regression from 2.0 where the camera data that is saved to the DYN file is not used to set the nodes camera view on deserialization. Previously it would always reset to default. Now it will set the camera to the view that was saved to the file.
  2. Fix regression from 2.0 where the node canvas size that is saved to the DYN file is not used to set the watch node size on deserialization. Previously it would always reset to the default 200 x 200. Now it will restore the watch size on canvas to the size that was saved to file.
  3. Change the behavior for Watch3D to always show geometry from connected node regardless of the nodes preview state. In the past the Watch3D node had functionality that gave the user more control over what geometry was displayed within the node (ie visible upstream). Currently the node is only limited to showing a subset of geometry that is visible in the Background Preview. This limits the user ability to visualize subsets of geometry independently. This change will allow the user to visualize geometry in Watch3d nodes independent of the preview state set on the node.

Declarations

Check these if you believe they are true

  • [x] The codebase is in a better state after this PR
  • [x] Is documented according to the standards
  • [x] The level of testing this PR includes is appropriate
  • [ ] User facing strings, if any, are extracted into *.resx files
  • [ ] All tests pass using the self-service CI.
  • [ ] Snapshot of UI changes, if any.
  • [ ] Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • [ ] This PR modifies some build requirements and the readme is updated

Reviewers

TBD

FYIs

saintentropy avatar Oct 15 '21 20:10 saintentropy