Dynamo icon indicating copy to clipboard operation
Dynamo copied to clipboard

proposal: selected geometry is highlighted with xray outline.

Open mjkkirschner opened this issue 4 years ago • 2 comments

Purpose

This PR uses a standard helix post effect shader to display hidden geometry (occluded) with an xray outline post effect. Note that in newer versions of helix the color is more saturated - in this pr I've scaled down our selection color by .5f because the shader multiplies the color and makes it quite bright. We'll have to evaluate the color changes when moving to new helix versions.

The highlight works for points, meshes and lines.

Screen Shot 2021-01-20 at 5 08 30 PM Screen Shot 2021-01-20 at 5 08 35 PM Screen Shot 2021-01-20 at 5 09 01 PM

PR also removes some dead references to dlls we no longer require.

TODO -

  • [ ] new tests
  • [ ] update image comparison tests that will now fail.

Declarations

Check these if you believe they are true

  • [ ] The codebase is in a better state after this PR
  • [ ] Is documented according to the standards
  • [ ] The level of testing this PR includes is appropriate
  • [ ] User facing strings, if any, are extracted into *.resx files
  • [ ] All tests pass using the self-service CI.
  • [x] Snapshot of UI changes, if any.
  • [x] Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • [ ] This PR modifies some build requirements and the readme is updated

mjkkirschner avatar Jan 20 '21 22:01 mjkkirschner

@mjkkirschner what was it you were saying about the x-ray outline not appearing on a white background preview using the current helix version?

aparajit-pratap avatar Jan 21 '21 16:01 aparajit-pratap

The way the color is blended with a white background has been changed in later versions of helix so that the blended color is less bright. Today it becomes white and is not very visible on a bright background.

mjkkirschner avatar Jan 21 '21 18:01 mjkkirschner