VMF2OBJ icon indicating copy to clipboard operation
VMF2OBJ copied to clipboard

Cleanup needed

Open TheBlizWiz opened this issue 4 years ago • 1 comments

Now that the thing is confirmed to work, we ought to clean it up a bit. Ex: We have a gson that we imported but the only time it's ever used is in code that's commented out.

I also suggest we change all the public static final variables at the top to private variables and create some getters/setters for them since having them open like that causes security issues

TheBlizWiz avatar Jun 28 '20 19:06 TheBlizWiz

I agree. Java is very much not my preferred language, and I spend almost all my time working with procedural languages so there's probably a lot of places where better Java/OOP principles can be used. I'll slowly start cleaning stuff up when I notice something is off.

Dylancyclone avatar Jun 28 '20 22:06 Dylancyclone