react-native-fast-image icon indicating copy to clipboard operation
react-native-fast-image copied to clipboard

Gif images play faster in iPhone 13 pro max

Open RashVenkat6795 opened this issue 1 year ago • 8 comments

Describe the bug GIF images which are at normal speed in phones, plays at very fast rate in iPhone 13 pro max

To Reproduce Steps to reproduce the behavior if possible, or a link to a reproduction repo: Play a gif image in iPhone 13 pro max

Expected behavior GIF should play at normal speed

Screenshots

Dependency versions

  • React Native version: 0.64.0
  • React version: 17.0.1
  • React Native Fast Image version: 8.5.5

RashVenkat6795 avatar Jul 22 '22 11:07 RashVenkat6795

I am also facing this issue.

I have experienced this from RN v0.64-0.66.

I can confirm gif speed is working as it should with the RN <Image> Component.

nica0012 avatar Jul 29 '22 02:07 nica0012

You need to patch the SDWebImage dependency to 5.12

safaiyeh avatar Aug 09 '22 00:08 safaiyeh

@safaiyeh why though? Since it's happening specific to iPhone 13 pro max, it could be because of the refresh rate?

https://discussions.apple.com/thread/253799298

Nehal-Sanklecha avatar Aug 14 '22 08:08 Nehal-Sanklecha

@safaiyeh why though? Since it's happening specific to iPhone 13 pro max, it could be because of the refresh rate?

https://discussions.apple.com/thread/253799298

yup! its exactly that, SDWebImage 5.12 resolves the issue

safaiyeh avatar Aug 19 '22 23:08 safaiyeh

@DylanVann Sounds like a pretty simple update and very annoying, maybe you could have a look and help us on a quick fix ? :-) Thanks

ScreamZ avatar Oct 30 '22 08:10 ScreamZ

Fixed in SDWebImage 5.15.3: https://github.com/SDWebImage/SDWebImage/issues/3491 Till this package gets updated I made myself a patch:

/patches/react-native-fast-image+8.6.3.patch:

diff --git a/node_modules/react-native-fast-image/RNFastImage.podspec b/node_modules/react-native-fast-image/RNFastImage.podspec
index db0fada..0c0cce5 100644
--- a/node_modules/react-native-fast-image/RNFastImage.podspec
+++ b/node_modules/react-native-fast-image/RNFastImage.podspec
@@ -16,6 +16,6 @@ Pod::Spec.new do |s|
   s.source_files  = "ios/**/*.{h,m}"

   s.dependency 'React-Core'
-  s.dependency 'SDWebImage', '~> 5.11.1'
+  s.dependency 'SDWebImage', '~> 5.15.3'
   s.dependency 'SDWebImageWebPCoder', '~> 0.8.4'
 end

postinstall / patch-package, do yarn install, rm -rf Pods, rm Podfile.lock, pod install, works for me, idk if it breaks anything.

csaq5507 avatar Feb 20 '23 09:02 csaq5507

@DylanVann When will this bug be fixed?

jiangwei1995 avatar Aug 04 '23 12:08 jiangwei1995

Fixed in SDWebImage 5.15.3: SDWebImage/SDWebImage#3491 Till this package gets updated I made myself a patch:

/patches/react-native-fast-image+8.6.3.patch:

diff --git a/node_modules/react-native-fast-image/RNFastImage.podspec b/node_modules/react-native-fast-image/RNFastImage.podspec
index db0fada..0c0cce5 100644
--- a/node_modules/react-native-fast-image/RNFastImage.podspec
+++ b/node_modules/react-native-fast-image/RNFastImage.podspec
@@ -16,6 +16,6 @@ Pod::Spec.new do |s|
   s.source_files  = "ios/**/*.{h,m}"

   s.dependency 'React-Core'
-  s.dependency 'SDWebImage', '~> 5.11.1'
+  s.dependency 'SDWebImage', '~> 5.15.3'
   s.dependency 'SDWebImageWebPCoder', '~> 0.8.4'
 end

postinstall / patch-package, do yarn install, rm -rf Pods, rm Podfile.lock, pod install, works for me, idk if it breaks anything.

This is the exact answer! Thanks!

Gautham495 avatar Mar 22 '24 13:03 Gautham495