react-native-fast-image Update SDWebImage to the latest version (5.12.1)

Update SDWebImage to the latest version (5.12.1)

Open neilgupta opened this issue 2 years ago • 33 comments

We need this specifically to fix a bug on the latest iPhone and iPad Pros with ProMotion display where the gif does not animate at the right frame rate: https://github.com/SDWebImage/SDWebImage/pull/3280

Oct 27 '21 23:10 neilgupta

@DylanVann would you mind merging this?

Feb 18 '22 21:02 kevinavery

would love to see this released as well

Feb 22 '22 21:02 skylarbarrera

👀

Mar 10 '22 20:03 skylarbarrera

@DylanVann This should be merged - we had to create a custom PodSpec in order to support iPhone 13 screens - otherwise GIF speed is way off.

Mar 12 '22 20:03 kzetxa

any update here?

Mar 24 '22 17:03 skylarbarrera

bump 👍

Mar 31 '22 01:03 musnit

I ran into the same issue with animated .webm files on iPhone 13. Applying this patch fixed the problem. Please merge.

Apr 06 '22 18:04 turbogerald

Why not change it to '~> 5' or '~> 5.12'? Why are the versions always pinned like this? Makes no sense to me.

Apr 07 '22 07:04 levino

@DylanVann , any updates on when this can be merged? This should solve a production issue for our users. Thanks!

Apr 28 '22 21:04 piorkowd

@DylanVann , any updates on when this can be merged? This should solve a production issue for our users. Thanks!

May 12 '22 20:05 piorkowd

@piorkowd Just use yarn patch or patch-package until this gets merged (which might be never, as it looks to me).

May 13 '22 06:05 levino

We need this specifically to fix a bug on the latest iPhone and iPad Pros with ProMotion display where the gif does not animate at the right frame rate: SDWebImage/SDWebImage#3280

where i can find the podspec file?

May 17 '22 12:05 ddikodroid

+1 cc @DylanVann

May 23 '22 23:05 carl0shd

@piorkowd Just use yarn patch or patch-package until this gets merged (which might be never, as it looks to me).

How does this work? I'm looking to give this a try.

Jul 29 '22 17:07 nica0012

@nica0012 instructions in patch-package readme are pretty straightforward, install patch-package following their instructions. Then open the node_modules/react-native-fast-image/RNFastImage.podspec in an editor, make the changes required and run yarn run patch-package react-native-fast-image and it'll create a patches folder with the diff, commit this to your repo and the next time you run yarn install the patch will be applied after the normal install process.

Jul 30 '22 06:07 levibuzolic

@DylanVann are you looking for additional contributors to help work through PRs and publish releases? I'd be happy to help get some of these patches/fixes through.

Jul 30 '22 06:07 levibuzolic

@nica0012 instructions in patch-package readme are pretty straightforward, install patch-package following their instructions. Then open the node_modules/react-native-fast-image/RNFastImage.podspec in an editor, make the changes required and run yarn run patch-package react-native-fast-image and it'll create a patches folder with the diff, commit this to your repo and the next time you run yarn install the patch will be applied after the normal install process.

yarn patch provides very similar functionality without an additional dependency.

Jul 30 '22 07:07 levino

Please merge this.